fix: Headless tasks in bridgeless mode (fixes #44255) #45100
Closed
+62
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
robik
force-pushed
the
robik/fix-headless-js-new-arch
branch
from
3bb9d4a
to
ac870aa
Compare
robik
changed the title
|
@robik are you blocked on something? (asking as this is marked as draft) |
|
@cortinico hey, I left a comment on the ticket about this :) |
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/HeadlessJsTaskService.java
Show resolved
Hide resolved
|
@arushikesarwani94 allrighty then! PR published :) |
|
@arushikesarwani94 can you import and merge this one? |
facebook-github-bot
added
the
Shared with Meta
|
@arushikesarwani94 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Jul 9, 2024
| protected ReactContext getReactContext() { | ||
| if (DefaultNewArchitectureEntryPoint.getBridgelessEnabled()) { | ||
| ReactHost reactHost = getReactHost(); | ||
| Assertions.assertNotNull(reactHost, "React host is null in newArchitecture"); |
There was a problem hiding this comment.
Suggested change
| Assertions.assertNotNull(reactHost, "React host is null in newArchitecture"); | |
| Assertions.assertNotNull(reactHost, "getReactHost() is null in New Architecture"); |
Comment on lines
+182
to
+184
| final ReactInstanceManager reactInstanceManager = | ||
| getReactNativeHost().getReactInstanceManager(); | ||
| return reactInstanceManager.getCurrentReactContext(); |
There was a problem hiding this comment.
put this in the else branch pls
|
@arushikesarwani94 merged this pull request in 9a1ae97. |
|
This pull request was successfully merged by @robik in 9a1ae97. When will my fix make it into a release? | How to file a pick request? |
chrfalch
added a commit
to expo/expo
that referenced
this pull request
Oct 18, 2024
On Android/newArch we're having issues with background tasks not working correctly. Background tasks are used in `expo-background-fetch`, `expo-location` and `expo-notifications` and are all driven by the module `expo-task-manager` and its core [TaskService](https://github.com/expo/expo/blob/031a3559dd669ed3edf1800a23eb1d86c52adb39/packages/expo-task-manager/android/src/main/java/expo/modules/taskManager/TaskService.java) class on Android. The `TaskService` class might be started from a background trigger like a push notification being received by the device. In some cases the app is not running, it might be stopped by the user, closed by the system or just not being started after a device reboot. In such a case the service will load the JS bundle in headless mode so that we can run code to make network/api calls, update storage etc. from within the background. This is handled by the [RNHeadlessAppLoader](https://github.com/expo/expo/blob/37ec6ba3c191ae10b315789397b9428da2d48d03/packages/expo-modules-core/android/src/main/java/expo/modules/adapters/react/apploader/RNHeadlessAppLoader.kt) class. On Android/newArch we're seeing some exceptions when trying to run JS code in headless mode: ``` Error: Exception in HostFunction: Could not enqueue microtask because they are disabled in this runtime, js engine: hermes ``` (We might also see other exceptions, but this is something I was reliably seeing). This seems to be caused by how we initialise our RN contexts when running headless. # How I found some similar issues in the RN repo where they updated the [HeadlessJSTaskService](https://github.com/robik/react-native/blob/ac870aa5e6a65f4253c2942aa1d8eaab408d1c90/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/HeadlessJsTaskService.java): [#45100](facebook/react-native#45100) This PR applies some of the same patterns for setting up the headless JS system in Expo. # Test plan Run background tests on Android using push-notifications, location and background fetch on both new and old arch.
chrfalch
added a commit
to expo/expo
that referenced
this pull request
Oct 23, 2024
…re (#32146) # Why On Android/newArch we're having issues with background tasks not working correctly. Background tasks are used in `expo-background-fetch`, `expo-location` and `expo-notifications` and are all driven by the module `expo-task-manager` and its core [TaskService](https://github.com/expo/expo/blob/031a3559dd669ed3edf1800a23eb1d86c52adb39/packages/expo-task-manager/android/src/main/java/expo/modules/taskManager/TaskService.java) class on Android. The `TaskService` class might be started from a background trigger like a push notification being received by the device. In some cases the app is not running, it might be stopped by the user, closed by the system or just not being started after a device reboot. In such a case the service will load the JS bundle in headless mode so that we can run code to make network/api calls, update storage etc. from within the background. This is handled by the [RNHeadlessAppLoader](https://github.com/expo/expo/blob/37ec6ba3c191ae10b315789397b9428da2d48d03/packages/expo-modules-core/android/src/main/java/expo/modules/adapters/react/apploader/RNHeadlessAppLoader.kt) class. On Android/newArch we're seeing some exceptions when trying to run JS code in headless mode: ``` Error: Exception in HostFunction: Could not enqueue microtask because they are disabled in this runtime, js engine: hermes ``` (We might also see other exceptions, but this is something I was reliably seeing). This seems to be caused by how we initialise our RN contexts when running headless. # How I found some similar issues in the RN repo where they updated the [HeadlessJSTaskService](https://github.com/robik/react-native/blob/ac870aa5e6a65f4253c2942aa1d8eaab408d1c90/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/HeadlessJsTaskService.java): [#45100](facebook/react-native#45100) This PR applies some of the same patterns for setting up the headless JS system in Expo's `RNHeadlessAppLoader`. # Test plan Run background tests on Android using push-notifications, location and background fetch on both new and old arch. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Kudo Chien <kudo@expo.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
HeadlessTaskService was to create a Bridge instance in bridgeless mode.
Fixes #44255
Changelog:
[ANDROID] [FIXED] - Fixed Headless JS tasks in New Architecture
Test Plan: