Do not depend on OSS SoLoader anymore #45873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60652007 |
|
This pull request was exported from Phabricator. Differential Revision: D60652007 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 9, 2024
Summary: Pull Request resolved: facebook#45873 I'm removing the Gradle dependency on OSS SoLoader and stubbing it with our own implementation. This will allow us to implement merging of further .so libraries and As Fresco also depends on SoLoader, I had to stub the `NativeLoader` dependency as well. Changelog: [Android] [Breaking] - Do not depend on OSS SoLoader anymore and do not expose Fresco `api` dependency. Differential Revision: D60652007
cortinico
force-pushed
the
export-D60652007
branch
from
23f1383
to
81d4be0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60652007 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 9, 2024
Summary: Pull Request resolved: facebook#45873 I'm removing the Gradle dependency on OSS SoLoader and stubbing it with our own implementation. This will allow us to implement merging of further .so libraries and As Fresco also depends on SoLoader, I had to stub the `NativeLoader` dependency as well. Changelog: [Android] [Breaking] - Do not depend on OSS SoLoader anymore and do not expose Fresco `api` dependency. Differential Revision: D60652007
cortinico
force-pushed
the
export-D60652007
branch
from
81d4be0
to
1c09297
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60652007 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 9, 2024
Summary: Pull Request resolved: facebook#45873 I'm removing the Gradle dependency on OSS SoLoader and stubbing it with our own implementation. This will allow us to implement merging of further .so libraries and As Fresco also depends on SoLoader, I had to stub the `NativeLoader` dependency as well. Changelog: [Android] [Breaking] - Do not depend on OSS SoLoader anymore and do not expose Fresco `api` dependency. Differential Revision: D60652007
cortinico
force-pushed
the
export-D60652007
branch
from
1c09297
to
b9aa763
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60652007 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 12, 2024
Summary: Pull Request resolved: facebook#45873 I'm removing the Gradle dependency on OSS SoLoader and stubbing it with our own implementation. This will allow us to implement merging of further .so libraries and As Fresco also depends on SoLoader, I had to stub the `NativeLoader` dependency as well. Changelog: [Android] [Breaking] - Do not depend on OSS SoLoader anymore and do not expose Fresco `api` dependency. Reviewed By: mdvacca Differential Revision: D60652007
cortinico
force-pushed
the
export-D60652007
branch
from
b9aa763
to
dfe5ef2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60652007 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 12, 2024
Summary: Pull Request resolved: facebook#45873 I'm removing the Gradle dependency on OSS SoLoader and stubbing it with our own implementation. This will allow us to implement merging of further .so libraries and As Fresco also depends on SoLoader, I had to stub the `NativeLoader` dependency as well. Changelog: [Android] [Breaking] - Do not depend on OSS SoLoader anymore and do not expose Fresco `api` dependency. Reviewed By: mdvacca Differential Revision: D60652007
cortinico
force-pushed
the
export-D60652007
branch
from
dfe5ef2
to
d41f169
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60652007 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 12, 2024
Summary: Pull Request resolved: facebook#45873 I'm removing the Gradle dependency on OSS SoLoader and stubbing it with our own implementation. This will allow us to implement merging of further .so libraries and As Fresco also depends on SoLoader, I had to stub the `NativeLoader` dependency as well. Changelog: [Android] [Breaking] - Do not depend on OSS SoLoader anymore and do not expose Fresco `api` dependency. Reviewed By: mdvacca Differential Revision: D60652007
cortinico
force-pushed
the
export-D60652007
branch
from
d41f169
to
0d4130b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60652007 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 12, 2024
Summary: Pull Request resolved: facebook#45873 I'm removing the Gradle dependency on OSS SoLoader and stubbing it with our own implementation. This will allow us to implement merging of further .so libraries and As Fresco also depends on SoLoader, I had to stub the `NativeLoader` dependency as well. Changelog: [Android] [Breaking] - Do not depend on OSS SoLoader anymore and do not expose Fresco `api` dependency. Reviewed By: mdvacca Differential Revision: D60652007
cortinico
force-pushed
the
export-D60652007
branch
from
0d4130b
to
6376ea3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60652007 |
cortinico
force-pushed
the
export-D60652007
branch
from
6376ea3
to
81fe174
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebook#45873 I'm removing the Gradle dependency on OSS SoLoader and stubbing it with our own implementation. This will allow us to implement merging of further .so libraries and As Fresco also depends on SoLoader, I had to stub the `NativeLoader` dependency as well. Changelog: [Android] [Breaking] - Do not depend on OSS SoLoader anymore and do not expose Fresco `api` dependency. Reviewed By: mdvacca Differential Revision: D60652007
Summary: Pull Request resolved: facebook#45873 I'm removing the Gradle dependency on OSS SoLoader and stubbing it with our own implementation. This will allow us to implement merging of further .so libraries and As Fresco also depends on SoLoader, I had to stub the `NativeLoader` dependency as well. Changelog: [Android] [Breaking] - Do not depend on OSS SoLoader anymore and do not expose Fresco `api` dependency. Reviewed By: mdvacca Differential Revision: D60652007
|
This pull request was exported from Phabricator. Differential Revision: D60652007 |
cortinico
force-pushed
the
export-D60652007
branch
from
81fe174
to
6d1539d
Compare
|
This pull request has been merged in 6dc01da. |
|
This pull request was successfully merged by @cortinico in 6dc01da When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm removing the Gradle dependency on OSS SoLoader and stubbing it with our own implementation.
This will allow us to implement merging of further .so libraries and
As Fresco also depends on SoLoader, I had to stub the
NativeLoaderdependency as well.Changelog:
[Android] [Breaking] - Do not depend on OSS SoLoader anymore and do not expose Fresco
apidependency.Differential Revision: D60652007