Fix type of callerContext #46039
Closed
Fix type of callerContext #46039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61332854 |
Summary: Pull Request resolved: facebook#46039 Broke during Kotlin conversion I assume Image onSubmit events were failing with ``` FdingControllerListener E InternalListener exception in onSubmit E java.lang.NullPointerException: Parameter specified as non-null is null: method com.facebook.react.views.image.ReactImageView$setShouldNotifyLoadEvents$1.onSubmit, parameter callerContext E at com.facebook.react.views.image.ReactImageView$setShouldNotifyLoadEvents$1.onSubmit(Unknown Source:9) E at com.facebook.drawee.controller.ForwardingControllerListener.onSubmit(ForwardingControllerListener.java:75) E at com.facebook.drawee.controller.AbstractDraweeController.reportSubmit(AbstractDraweeController.java:832) E at com.facebook.drawee.controller.AbstractDraweeController.submitRequest(AbstractDraweeController.java:578) E at com.facebook.drawee.controller.AbstractDraweeController.onAttach(AbstractDraweeController.java:468) E at com.facebook.drawee.view.DraweeHolder.attachController(DraweeHolder.java:252) E at com.facebook.drawee.view.DraweeHolder.attachOrDetachController(DraweeHolder.java:269) E at com.facebook.drawee.view.DraweeHolder.onAttach(DraweeHolder.java:87) E at com.facebook.drawee.view.DraweeView.doAttach(DraweeView.java:208) E at com.facebook.drawee.view.DraweeView.onAttach(DraweeView.java:194) E at com.facebook.drawee.view.DraweeView.onAttachedToWindow(DraweeView.java:168) E at android.view.View.dispatchAttachedToWindow(View.java:20812) E at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497) E at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497) E at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3497) E at android.view.ViewGroup.addViewInner(ViewGroup.java:5290) E at android.view.ViewGroup.addView(ViewGroup.java:5076) E at com.facebook.react.views.view.ReactViewGroup.addView(ReactViewGroup.java:591) E at android.view.ViewGroup.addView(ViewGroup.java:5016) E at com.facebook.react.views.view.ReactClippingViewManager.addView(ReactClippingViewManager.java:41) E at com.facebook.react.views.view.ReactClippingViewManager.addView(ReactClippingViewManager.java:21) E at com.facebook.react.fabric.mounting.SurfaceMountingManager.addViewAt(SurfaceMountingManager.java:412) E at com.facebook.react.fabric.mounting.mountitems.IntBufferBatchMountItem.execute(IntBufferBatchMountItem.java:119) E at com.facebook.react.fabric.mounting.MountItemDispatcher.executeOrEnqueue(MountItemDispatcher.java:387) E at com.facebook.react.fabric.mounting.MountItemDispatcher.dispatchMountItems(MountItemDispatcher.java:294) E at com.facebook.react.fabric.mounting.MountItemDispatcher.tryDispatchMountItems(MountItemDispatcher.java:127) E at com.facebook.react.fabric.FabricUIManager$DispatchUIFrameCallback.doFrameGuarded(FabricUIManager.java:1362) E at com.facebook.react.fabric.GuardedFrameCallback.doFrame(GuardedFrameCallback.kt:22) E at com.facebook.react.modules.core.ReactChoreographer$frameCallback$1.doFrame(ReactChoreographer.kt:59) E at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1035) E at android.view.Choreographer.doCallbacks(Choreographer.java:845) E at android.view.Choreographer.doFrame(Choreographer.java:775) E at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022) E at android.os.Handler.handleCallback(Handler.java:938) E at android.os.Handler.dispatchMessage(Handler.java:99) E at android.os.Looper.loopOnce(Looper.java:214) E at android.os.Looper.loop(Looper.java:304) E at android.app.ActivityThread.main(ActivityThread.java:7918) E at java.lang.reflect.Method.invoke(Native Method) E at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) E at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1010) ``` Changelog: [Internal] Reviewed By: fabriziocucci Differential Revision: D61332854
|
This pull request was exported from Phabricator. Differential Revision: D61332854 |
javache
force-pushed
the
export-D61332854
branch
from
985625f
to
b722f86
Compare
|
This pull request has been merged in f8aa786. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Broke during Kotlin conversion I assume
Image onSubmit events were failing with
Changelog: [Internal]
Differential Revision: D61332854