Fix publish template url for GHA action #46040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The URL to dispatch the workflow was not correct, see [0]. ## Changelog: Internal [0] https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event ## Internal: For S441191, see the job launched: - https://github.com/react-native-community/template/actions/runs/10404141179/job/28811993693 {F1806960111} Differential Revision: D61333084
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61333084 |
tido64
reviewed
Aug 15, 2024
| @@ -201,10 +201,10 @@ jobs: | |||
| VERSION=$(grep -oE '\d+\.\d+' <<< "${{ github.ref_name }}" | { read version; echo "$version-stable"; }) | |||
| echo "VERSION=$VERSION" >> $GITHUB_OUTPUT | |||
|
|
|||
| curl -L -X POST https://api.github.com/repos/react-native-community/template/release.yaml/dispatches \ | |||
| curl -L https://api.github.com/repos/react-native-community/template/actions/workflows/release.yaml/dispatches | |||
There was a problem hiding this comment.
Wouldn't it be safer to use the client library? https://github.com/octokit/plugin-rest-endpoint-methods.js
|
This pull request has been merged in 15c9961. |
|
This pull request was successfully merged by @blakef in 15c9961 When will my fix make it into a release? | How to file a pick request? |
blakef
added a commit
that referenced
this pull request
Aug 19, 2024
Summary: Pull Request resolved: #46040 The URL to dispatch the workflow was not correct, see [0]. ## Changelog: [Internal] [0] https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event ## Internal: For S441191, see the job launched: - https://github.com/react-native-community/template/actions/runs/10404141179/job/28811993693 {F1806960111} Reviewed By: cipolleschi Differential Revision: D61333084 fbshipit-source-id: 62b20d792b9c667b3ee80d6d446423a6d24a67c2
|
This pull request was successfully merged by @blakef in c22803a. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The URL to dispatch the workflow was not correct, see [0].
Changelog: [Internal]
[0] https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event
Differential Revision: D61333084