fix(iOS): displaying irregular borders on iOS old architecture #46091
Conversation
facebook-github-bot
added
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| layer.mask = mask; | ||
|
|
||
| for (UIView *subview in self.subviews) { | ||
| if ([subview isKindOfClass:[UIImageView class]]) { |
There was a problem hiding this comment.
There has been a suggestion from @NickGerleman to try and look for a more general approach.
It's not just images that should present this behavior, but all the components that have as tyle with overflow: hidden. Images have that style by default.
Do you think we can find a way to check if the style applied has the overflow property set to hidden, rather than checking if the subview is an Image?
There was a problem hiding this comment.
Seems like the overflow property is used here to set clipsToBounds on the old architecture.
|
I had a problem with the mask not correctly clipping other subviews. I am still unsure why that is, but I implemented the idea that @joevilches proposed about decoupling the border and background into two layers on Fabric. I don't know whether I should code the same on the old architecture since borders are implemented a little bit differently there. Also, I am not sure what initial value the
|
There was a problem hiding this comment.
a part for a nit, the code looks good for me. I'll forward the PR to @joevilches for his opinion.
packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
Outdated
Show resolved
Hide resolved
…w/RCTViewComponentView.mm Co-authored-by: Riccardo Cipolleschi <riccardo.cipolleschi@gmail.com>
|
Hey @coado, thanks for putting the extra time into this! Didn't see this and am about to put up a PR for the same thing, but the scope is limited to new arch. Do you mind limiting this PR to old arch? There are a few things with clipping that I added in as well that will make it more compliant. Sorry for the inconvenience! |
Hey, no problem! Do you think we could introduce separate layers for border and background also on the old architecture or is it better to not change current design? |
Summary:
This PR solves the issue with drawing borders on the old architecture by setting a mask on the
UIImageViewsubview (pretty much the same as in the earlier PR for Fabric). Also, it extracts the previouscreateMaskLayerfunction toRCTBorderDrawing.m, so it can be used in bothRCTView.mandRCTViewComponentView.mfiles and changes its name toRCTCreateMaskLayer.Changelog:
[IOS][FIXED] - fixes displaying irregular borders on the old architecture.
Test Plan: