Changing timeStamp to timestamp to match ios property name. Fixes #4046

[msathis]

Fixes #4046

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @mkonicek and @dmmiller to be potential reviewers.

[mkonicek]

Thanks for the fix! How did you test this? Does anything depend on this being "timeStamp"?

[dmmiller]

Why did you choose iOS instead of Android as the canonical one? Looking through the code, it looks like it will work either way except in ImageCropper.android which seems to require it be timeStamp.

[msathis]

As @dmmiller suggested it's a breaking change. Someone with good knowledge about the product should look into this. Sorry for half baked PR :(

[christopherdro]

@msathis 👍 You had good intentions I think you have here is fine.
I don't see any other code that would conflict with this change. Going to open this back up.

@dmmiller Could you point me to the file containing ImageCropper.android? I can't seem to find anything like that.

I feel like using timestamp over timeStamp keeps things consistent not only across iOS but other languages in the react-native codebase. Plus, timestamp is considered to be one word so it shouldn't need to be written in camel case. :)

[mkonicek]

The ImageCropper is part of the Ads Manager unfortunately. Have to fix it manually..

[mkonicek]

@facebook-github-bot import

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/444925209028390/int_phab to review.

[satya164]

Seems the import failed. Let's try again.

[satya164]

@facebook-github-bot shipit

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/444925209028390/int_phab to review.

[satya164]

ping @mkonicek

[mkonicek]

@christopherdro, @msathis, @dmmiller Looks like the web spec uses timeStamp:
https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp
http://www.w3.org/TR/DOM-Level-3-Events/

Should we change the iOS key to timeStamp instead?

[dmmiller]

(y)

I vote we go with the web. Let's change iOS.

[satya164]

@msathis Can you update the PR?

[msathis]

@satya164 Yes. I will do it today.

[mkonicek]

Hey @msathis! Thanks for making the pull request, but we are closing it due to inactivity (80 days with no activity) to make sure all pull requests are either being worked on or closed. If you want to get your proposed changes merged, please rebase your branch with master and send a new pull request :)

Based on the comments above, we should change iOS to timeStamp.

[mkonicek]

Update: this has now been fixed by @andreicoman11, it's timeStamp on both platforms.

[andreicoman11]

Minor correction: we went for timestamp instead.