Refactor/ bugfix for ReactModalHostView #46326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62177564 |
|
This pull request was exported from Phabricator. Differential Revision: D62177564 |
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: facebook#46326 - renaming variabled to make intent more clear - `dialog` -> `dialogWindow` to distinguish with `activity.window` - `hostView` -> `dialogRootViewGroup` as name was confusing. - `ReactModalHostView` creates and manages `DialogRootViewGroup` but it used as contentView for the Dialog. - bug fixes Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D62177564
alanleedev
force-pushed
the
export-D62177564
branch
from
7191e79
to
7ba724e
Compare
alanleedev
pushed a commit
to alanleedev/react-native
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: facebook#46326 - renaming variabled to make intent more clear - `dialog` -> `dialogWindow` to distinguish with `activity.window` - `hostView` -> `dialogRootViewGroup` as name was confusing. - `ReactModalHostView` creates and manages `DialogRootViewGroup` but it used as contentView for the Dialog. - bug fixes Changelog: [Internal] Differential Revision: D62177564 Reviewed By: mdvacca
alanleedev
pushed a commit
to alanleedev/react-native
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: facebook#46326 - renaming variabled to make intent more clear - `dialog` -> `dialogWindow` to distinguish with `activity.window` - `hostView` -> `dialogRootViewGroup` as name was confusing. - `ReactModalHostView` creates and manages `DialogRootViewGroup` but it used as contentView for the Dialog. - bug fixes Changelog: [Internal] Differential Revision: D62177564 Reviewed By: mdvacca
Summary: Pull Request resolved: facebook#46326 - renaming variabled to make intent more clear - `dialog` -> `dialogWindow` to distinguish with `activity.window` - `hostView` -> `dialogRootViewGroup` as name was confusing. - `ReactModalHostView` creates and manages `DialogRootViewGroup` but it used as contentView for the Dialog. - bug fixes Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D62177564
|
This pull request was exported from Phabricator. Differential Revision: D62177564 |
alanleedev
force-pushed
the
export-D62177564
branch
from
7ba724e
to
29402a2
Compare
alanleedev
pushed a commit
to alanleedev/react-native
that referenced
this pull request
Sep 7, 2024
Summary: Pull Request resolved: facebook#46326 - renaming variabled to make intent more clear - `dialog` -> `dialogWindow` to distinguish with `activity.window` - `hostView` -> `dialogRootViewGroup` as name was confusing. - `ReactModalHostView` creates and manages `DialogRootViewGroup` but it used as contentView for the Dialog. - bug fixes Changelog: [Internal] Differential Revision: D62177564 Reviewed By: mdvacca
|
This pull request has been merged in 79e4ed2. |
|
This pull request was successfully merged by @alanleedev in 79e4ed2 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
dialog->dialogWindowto distinguish withactivity.windowhostView->dialogRootViewGroupas name was confusing.ReactModalHostViewcreates and managesDialogRootViewGroupbut it used as contentView for the Dialog.Changelog: [Internal]
Differential Revision: D62177564