code cleanup for depreacted OS version #46390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62362059 |
|
This pull request was exported from Phabricator. Differential Revision: D62362059 |
alanleedev
force-pushed
the
export-D62362059
branch
from
11a3d0e
to
1793475
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62362059 |
alanleedev
force-pushed
the
export-D62362059
branch
from
1793475
to
367d38b
Compare
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: facebook#46390 As React Native's minSdkVersion is not 24, clean up version checks and code that is using deprecated version from OSS Changelog: [General][Android] - code cleanup for minSdkVersion 24 Reviewed By: philIip Differential Revision: D62362059
Summary: Pull Request resolved: facebook#46390 As React Native's minSdkVersion is not 24, clean up version checks and code that is using deprecated version from OSS Changelog: [Internal] - code cleanup for minSdkVersion 24 Reviewed By: philIip Differential Revision: D62362059
|
This pull request was exported from Phabricator. Differential Revision: D62362059 |
alanleedev
force-pushed
the
export-D62362059
branch
from
367d38b
to
a9b4d82
Compare
|
This pull request has been merged in 3244a5e. |
|
This pull request was successfully merged by @alanleedev in 3244a5e When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As React Native's minSdkVersion is not 24, clean up version checks and code that is using deprecated version from OSS
Changelog:
[Internal] - code cleanup for minSdkVersion 24
Differential Revision: D62362059