add inset based margins to RedBox #46391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62362105 |
Summary: Pull Request resolved: facebook#46391 **Issue:** RedBox displays early error before JS Error handling is properly setup. On Android 15, targetSdk 35 (forced edge-to-edge), dialog overlaps with system bars making it difficult to use. **Solution** Add inset based margins so content does not overlap with system bars. Changelog: [Android][Fixed] - RedBox content overlapping with system bars on Android 15 forced edge-to-edge Differential Revision: D62362105
|
This pull request was exported from Phabricator. Differential Revision: D62362105 |
alanleedev
force-pushed
the
export-D62362105
branch
from
983dc9d
to
3e72999
Compare
|
This pull request has been merged in 97b661c. |
|
This pull request was successfully merged by @alanleedev in 97b661c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue:
RedBox displays early error before JS Error handling is properly setup.
On Android 15, targetSdk 35 (forced edge-to-edge), dialog overlaps with system bars making it difficult to use.
Solution
Add inset based margins so content does not overlap with system bars.
Changelog:
[Android][Fixed] - RedBox content overlapping with system bars on Android 15 forced edge-to-edge
Differential Revision: D62362105