ReactRootView is Nullable in ReactDelegate #46440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62514424 |
|
This pull request was exported from Phabricator. Differential Revision: D62514424 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Sep 11, 2024
Summary: Pull Request resolved: facebook#46440 ReactDelegate does not properly annotate the ReactRootView field as Nullable. This fixes that. ## Changelog [Android][Fixed] Use appropriate Nullable attribute for ReactRootView field in ReactDelegate Reviewed By: philIip Differential Revision: D62514424
rozele
force-pushed
the
export-D62514424
branch
from
5faf2e5 to
1030441
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62514424 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Sep 11, 2024
Summary: Pull Request resolved: facebook#46440 ReactDelegate does not properly annotate the ReactRootView field as Nullable. This fixes that. ## Changelog [Android][Fixed] Use appropriate Nullable attribute for ReactRootView field in ReactDelegate Reviewed By: philIip Differential Revision: D62514424
rozele
force-pushed
the
export-D62514424
branch
from
1030441 to
ea8eda7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62514424 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Sep 11, 2024
Summary: Pull Request resolved: facebook#46440 ReactDelegate does not properly annotate the ReactRootView field as Nullable. This fixes that. ## Changelog [Android][Fixed] Use appropriate Nullable attribute for ReactRootView field in ReactDelegate Reviewed By: philIip Differential Revision: D62514424
rozele
force-pushed
the
export-D62514424
branch
from
ea8eda7 to
c07356f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62514424 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Sep 11, 2024
Summary: Pull Request resolved: facebook#46440 ReactDelegate does not properly annotate the ReactRootView field as Nullable. This fixes that. ## Changelog [Android][Fixed] Use appropriate Nullable attribute for ReactRootView field in ReactDelegate Reviewed By: philIip Differential Revision: D62514424
rozele
force-pushed
the
export-D62514424
branch
from
c07356f to
b316752
Compare
Summary: Pull Request resolved: facebook#46440 ReactDelegate does not properly annotate the ReactRootView field as Nullable. This fixes that. ## Changelog [Android][Fixed] Use appropriate Nullable attribute for ReactRootView field in ReactDelegate Reviewed By: philIip Differential Revision: D62514424
|
This pull request was exported from Phabricator. Differential Revision: D62514424 |
rozele
force-pushed
the
export-D62514424
branch
from
b316752 to
16d1a47
Compare
|
This pull request has been merged in cbddcfc. |
|
This pull request was successfully merged by @rozele in cbddcfc When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ReactDelegate does not properly annotate the ReactRootView field as Nullable. This fixes that.
Changelog
[Android][Fixed] Use appropriate Nullable attribute for ReactRootView field in ReactDelegate
Differential Revision: D62514424