Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement outline properties on iOS #46444

Closed
wants to merge 1 commit into from

Conversation

jorge-cab
Copy link
Contributor

Summary:
This diff adds:

outline-width: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width
outline-color: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color
outline-style: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style
outline-offset: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset

Using BackgroundStyleApplicator

Changelog: [iOS] [Added] - Outline properties outline-width, outline-color, outline-style & outline-offset

Differential Revision: D62273339

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62273339

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62273339

jorge-cab added a commit to jorge-cab/react-native that referenced this pull request Sep 11, 2024
Summary:
Pull Request resolved: facebook#46444

This diff adds:

`outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width
`outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color
`outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style
`outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset

Using `BackgroundStyleApplicator`

Changelog: [iOS] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset`

Differential Revision: D62273339
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62273339

jorge-cab added a commit to jorge-cab/react-native that referenced this pull request Sep 11, 2024
Summary:
Pull Request resolved: facebook#46444

This diff adds:

`outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width
`outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color
`outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style
`outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset

Using `BackgroundStyleApplicator`

Changelog: [iOS] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset`

Differential Revision: D62273339
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62273339

jorge-cab added a commit to jorge-cab/react-native that referenced this pull request Sep 12, 2024
Summary:
Pull Request resolved: facebook#46444

This diff adds:

`outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width
`outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color
`outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style
`outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset

Using `BackgroundStyleApplicator`

Changelog: [iOS] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset`

Differential Revision: D62273339
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62273339

jorge-cab added a commit to jorge-cab/react-native that referenced this pull request Sep 13, 2024
Summary:
Pull Request resolved: facebook#46444

This diff adds:

`outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width
`outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color
`outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style
`outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset

Using `BackgroundStyleApplicator`

Changelog: [iOS] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset`

Differential Revision: D62273339
Summary:
Pull Request resolved: facebook#46444

This diff adds:

`outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width
`outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color
`outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style
`outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset

Using `BackgroundStyleApplicator`

Changelog: [iOS] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset`

Differential Revision: D62273339
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62273339

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1288e38.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @jorge-cab in 1288e38

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants