-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-native-xcode): Add back BUNDLE_COMMAND #46495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this. I believe we have to pick this in 0.75 and 0.76, correct?
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cipolleschi merged this pull request in cf42288. |
This pull request was successfully merged by @Vin-Xi in cf42288 When will my fix make it into a release? | How to file a pick request? |
Yes, this is present from 0.75 onwards so it should be picked in both 0.75 and 0.76. |
Summary: In this PR #45560 the BUNDLE_COMMAND initialization was removed while it is still being used. Without it, building from Xcode throws unknown options error for Physical iOS devices. I have just brought back the initialization from the PR before that, so the bundle phase is successful. ## Changelog: [IOS][Fixed] - Add back the BUNDLE_COMMAND Pull Request resolved: #46495 Test Plan: I have bundled release builds in Xcode. Everything seems to be fine. Reviewed By: cortinico Differential Revision: D62846877 Pulled By: cipolleschi fbshipit-source-id: 3f07e8c0bc5acf98177582f1fee9a55ae77b31a1
I am still getting this on 0.75.3, I have applied the fix manually, everything runs smoothly in yarn but as soon as I try archiving in XCode 16 I keep getting.. anyone else still having this issue?
|
Summary: In this PR #45560 the BUNDLE_COMMAND initialization was removed while it is still being used. Without it, building from Xcode throws unknown options error for Physical iOS devices. I have just brought back the initialization from the PR before that, so the bundle phase is successful. ## Changelog: [IOS][Fixed] - Add back the BUNDLE_COMMAND Pull Request resolved: #46495 Test Plan: I have bundled release builds in Xcode. Everything seems to be fine. Reviewed By: cortinico Differential Revision: D62846877 Pulled By: cipolleschi fbshipit-source-id: 3f07e8c0bc5acf98177582f1fee9a55ae77b31a1
i have add this code manually but no works, still have a issue |
Summary:
In this PR #45560 the BUNDLE_COMMAND initialization was removed while it is still being used. Without it, building from Xcode throws unknown options error for Physical iOS devices.
I have just brought back the initialization from the PR before that, so the bundle phase is successful.
Changelog:
[IOS][Fixed] - Add back the BUNDLE_COMMAND
Test Plan:
I have bundled release builds in Xcode. Everything seems to be fine.