Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native-xcode): Add back BUNDLE_COMMAND #46495

Closed
wants to merge 1 commit into from

Conversation

Vin-Xi
Copy link
Contributor

@Vin-Xi Vin-Xi commented Sep 14, 2024

Summary:

In this PR #45560 the BUNDLE_COMMAND initialization was removed while it is still being used. Without it, building from Xcode throws unknown options error for Physical iOS devices.

I have just brought back the initialization from the PR before that, so the bundle phase is successful.

Changelog:

[IOS][Fixed] - Add back the BUNDLE_COMMAND

Test Plan:

I have bundled release builds in Xcode. Everything seems to be fine.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 14, 2024
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. I believe we have to pick this in 0.75 and 0.76, correct?

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 17, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in cf42288.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Vin-Xi in cf42288

When will my fix make it into a release? | How to file a pick request?

@Vin-Xi
Copy link
Contributor Author

Vin-Xi commented Sep 17, 2024

Yes, this is present from 0.75 onwards so it should be picked in both 0.75 and 0.76.

blakef pushed a commit that referenced this pull request Sep 23, 2024
Summary:
In this PR #45560  the BUNDLE_COMMAND initialization was removed while it is still being used. Without it, building from Xcode throws unknown options error for Physical iOS devices.

I have just brought back the initialization from the PR before that, so the bundle phase is successful.

## Changelog:
[IOS][Fixed] - Add back the BUNDLE_COMMAND

Pull Request resolved: #46495

Test Plan: I have bundled release builds in Xcode. Everything seems to be fine.

Reviewed By: cortinico

Differential Revision: D62846877

Pulled By: cipolleschi

fbshipit-source-id: 3f07e8c0bc5acf98177582f1fee9a55ae77b31a1
@fabioruxo
Copy link

I am still getting this on 0.75.3, I have applied the fix manually, everything runs smoothly in yarn but as soon as I try archiving in XCode 16 I keep getting.. anyone else still having this issue?

CommandError: Unknown arguments: --config-cmd, --config-cmd Command PhaseScriptExecution failed with a nonzero exit code

blakef pushed a commit that referenced this pull request Sep 30, 2024
Summary:
In this PR #45560  the BUNDLE_COMMAND initialization was removed while it is still being used. Without it, building from Xcode throws unknown options error for Physical iOS devices.

I have just brought back the initialization from the PR before that, so the bundle phase is successful.

## Changelog:
[IOS][Fixed] - Add back the BUNDLE_COMMAND

Pull Request resolved: #46495

Test Plan: I have bundled release builds in Xcode. Everything seems to be fine.

Reviewed By: cortinico

Differential Revision: D62846877

Pulled By: cipolleschi

fbshipit-source-id: 3f07e8c0bc5acf98177582f1fee9a55ae77b31a1
@kodeandoec
Copy link

i have add this code manually but no works, still have a issue
Command PhaseScriptExecution failed with a nonzero exit code
When i try to run on physica device no works, but when i run on simulator works fine
When i try to ARCHIVE project to publish to store i have the same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants