Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iOS): move boost compiler flags and folly dep name to centralized config #46513

Closed
wants to merge 1 commit into from
Closed

fix(iOS): move boost compiler flags and folly dep name to centralized config #46513

wants to merge 1 commit into from

Conversation

okwasniewski
Copy link
Contributor

Summary:

This PR does some further cleanup on the flags passed to cocoapods.

I've moved boost_compiler_flags and folly_dep_name to helpers.rb file.

Changelog:

[INTERNAL] [FIXED] - move boost compiler flags and folly dep name to centralized config

Test Plan:

CI Green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 16, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cipolleschi
cipolleschi approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spending time consolidating our build infra!

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 17, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 3c17bea.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @okwasniewski in 3c17bea

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okwasniewski @facebook-github-bot @react-native-bot @cipolleschi