Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Testing] Run Maestro tests also in debug mode #46573

Closed
wants to merge 4 commits into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Sep 19, 2024

Summary:

This change runs Maestro tests also in Debug mode, by starting Metro in background.

Changelog:

[Internal] - Add E2E tests in Debug mode too

Test Plan:

GHA must be green.
Successful run: https://github.com/facebook/react-native/actions/runs/11033322135?pr=46573

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 19, 2024
@cipolleschi cipolleschi force-pushed the cipolleschi/run-maestro-in-debug-mode branch 4 times, most recently from 3684337 to 04c8066 Compare September 19, 2024 12:57
@cipolleschi
Copy link
Contributor Author

/run-e2e-tests

@cipolleschi
Copy link
Contributor Author

/test-e2e

@cipolleschi cipolleschi force-pushed the cipolleschi/run-maestro-in-debug-mode branch 2 times, most recently from 28de771 to ab559c6 Compare September 19, 2024 14:06
@cipolleschi cipolleschi marked this pull request as draft September 19, 2024 14:54
@cipolleschi cipolleschi force-pushed the cipolleschi/run-maestro-in-debug-mode branch 18 times, most recently from a93c1e5 to 2944d97 Compare September 23, 2024 10:19
@cipolleschi cipolleschi force-pushed the cipolleschi/run-maestro-in-debug-mode branch 14 times, most recently from 7e7996c to 66f041e Compare September 26, 2024 09:02
@cipolleschi cipolleschi marked this pull request as ready for review September 26, 2024 09:02
@cipolleschi
Copy link
Contributor Author

/test-e2e

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/run-maestro-in-debug-mode branch from 66f041e to 17d6b34 Compare September 26, 2024 11:53
@cipolleschi
Copy link
Contributor Author

/test-e2e

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 26, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 94b7793.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in 94b7793

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants