-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS][New Architecture]: Fix applying of tintColor and progressViewOffset props for RefreshControl component #46628
Conversation
…ol component on iOS when newArchitecure enabled
Hi @TuTejsy! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Related issue: #46631 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TuTejsy thanks for working on the fix!
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cipolleschi merged this pull request in 19d468f. |
This pull request was successfully merged by @TuTejsy in 19d468f When will my fix make it into a release? | How to file a pick request? |
…trol component (#46628) Summary: While developing my project with New Architecture enabled I've found out that properties `tintColor` and `progressViewOffset` of component `RefreshControl` don't apply on iOS. This happens due to the lack of handling of these properties in the `RCTPullToRefreshViewComponentView.mm` class. The bug can be easily reproduced in RNTester app on RefreshControlExample.js screen, since it has property `tintColor="#ff0000"` (Red color), but RefreshControl renders with gray color: <img width="300" alt="RefreshControlExample.js" src="https://github.com/user-attachments/assets/10931204-dbe8-4cbd-9adc-d0f38319febd"> <img width="300" alt="gray Refresh Control" src="https://github.com/user-attachments/assets/e5d088e8-b3f5-46b8-9284-9b452232ad10"> <br /> <br /> This PR is opened to fix that by applying `tintColor` and `progressViewOffset` props to `_refreshControl` in `RCTPullToRefreshViewComponentView.mm` class. Fixes #46628 ## Changelog: [IOS][FIXED] - Fix applying of tintColor and progressViewOffset props for RefreshControl component with New Architecture enabled Pull Request resolved: #46628 Test Plan: 1. Run rn-tester app with New Architecture enabled on iOS 2. Open screen of RefreshControl component: <img width="300" alt="Снимок экрана 2024-09-24 в 19 48 49" src="https://github.com/user-attachments/assets/94a2d02d-f3e3-4e18-a345-87c22d4a2620"> 3. Open `/packages/rn-tester/js/examples/RefreshControl/RefreshControlExample.js` file and change properties `tintColor` and `progressViewOffset` of RefreshControl components on the line 85: <img width="300" alt="Снимок экрана 2024-09-24 в 22 01 19" src="https://github.com/user-attachments/assets/425826a6-d34c-4316-8484-e65f125a8b28"> 4. check that your changes applied: <img width="300" alt="Снимок экрана 2024-09-24 в 19 54 46" src="https://github.com/user-attachments/assets/b97621f1-b553-48c9-bc81-e04a99a7e099"> Reviewed By: cortinico Differential Revision: D63381050 Pulled By: cipolleschi fbshipit-source-id: 4f3aed8bd7a1e42ce2a75aa19740fd8be1623c86
Summary:
While developing my project with New Architecture enabled I've found out that properties
tintColor
andprogressViewOffset
of componentRefreshControl
don't apply on iOS. This happens due to the lack of handling of these properties in theRCTPullToRefreshViewComponentView.mm
class.The bug can be easily reproduced in RNTester app on RefreshControlExample.js screen, since it has property
tintColor="#ff0000"
(Red color), but RefreshControl renders with gray color:This PR is opened to fix that by applying
tintColor
andprogressViewOffset
props to_refreshControl
inRCTPullToRefreshViewComponentView.mm
class.Changelog:
[IOS][FIXED] - Fix applying of tintColor and progressViewOffset props for RefreshControl component with New Architecture enabled
Test Plan:
/packages/rn-tester/js/examples/RefreshControl/RefreshControlExample.js
file and change propertiestintColor
andprogressViewOffset
of RefreshControl components on the line 85: