fix: vertical scroll views are detected as horizontals #46836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Nice! Thank you so much! |
facebook-github-bot
added
the
Shared with Meta
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in ab8f3ff. |
|
This pull request was successfully merged by @coado in ab8f3ff When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There is a numerical issue that causes vertical scroll view to be considered as the horizontal one and leads to problems described here. The problem is no longer visible after checking if the scroll view is horizontal with float equality.
I am not sure if it also happens on Android, so I am leaving it as a draft for now.Fixes #46592
Changelog:
[IOS] [FIXED] - check if scroll view is horizontal with float equality.
Test Plan:
Tested on the repro provided in the above issue.