Skip to content

Update some React.AbstractComponent type to use component type #46855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SamChou19815 wants to merge 1 commit into from
Closed

Update some React.AbstractComponent type to use component type #46855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/react-native/Libraries/Components/Button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,10 +283,12 @@ type ButtonProps = $ReadOnly<{|
const Touchable: typeof TouchableNativeFeedback | typeof TouchableOpacity =
Platform.OS === 'android' ? TouchableNativeFeedback : TouchableOpacity;

const Button: React.AbstractComponent<
ButtonProps,
React.ElementRef<typeof Touchable>,
> = React.forwardRef((props: ButtonProps, ref) => {
type ButtonRef = React.ElementRef<typeof Touchable>;

const Button: component(
ref: React.RefSetter<ButtonRef>,
...props: ButtonProps
) = React.forwardRef((props: ButtonProps, ref: React.RefSetter<ButtonRef>) => {
const {
accessibilityLabel,
accessibilityState,
Expand Down
9 changes: 5 additions & 4 deletions packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1703,10 +1703,11 @@ exports[`public API should not change unintentionally Libraries/Components/Butto
declare const Touchable:
| typeof TouchableNativeFeedback
| typeof TouchableOpacity;
declare const Button: React.AbstractComponent<
ButtonProps,
React.ElementRef<typeof Touchable>,
>;
type ButtonRef = React.ElementRef<typeof Touchable>;
declare const Button: component(
ref: React.RefSetter<ButtonRef>,
...props: ButtonProps
);
declare export default typeof Button;
"
`;
Expand Down
9 changes: 4 additions & 5 deletions packages/react-native/src/private/components/HScrollViewNativeComponents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,10 @@ const HScrollViewNativeComponentForPlatform =
: ScrollViewNativeComponent;

// TODO: After upgrading to React 19, remove `forwardRef` from this component.
export const HScrollViewNativeComponent: React.AbstractComponent<
ScrollViewNativeProps,
TScrollViewNativeImperativeHandle,
// $FlowExpectedError[incompatible-type] - Flow cannot model imperative handles, yet.
> = forwardRef(function HScrollViewNativeComponent(
export const HScrollViewNativeComponent: component(
ref: React.RefSetter<TScrollViewNativeImperativeHandle>,
...ScrollViewNativeProps
) = forwardRef(function HScrollViewNativeComponent(
props: ScrollViewNativeProps,
ref: ?React.RefSetter<TScrollViewNativeImperativeHandle | null>,
): React.Node {
Expand Down
18 changes: 10 additions & 8 deletions packages/virtualized-lists/Lists/VirtualizedSectionList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,11 +601,13 @@ function ItemWithSeparator(props: ItemWithSeparatorProps): React.Node {
/* $FlowFixMe[class-object-subtyping] added when improving typing for this
* parameters */
// $FlowFixMe[method-unbinding]
module.exports = (VirtualizedSectionList: React.AbstractComponent<
React.ElementConfig<typeof VirtualizedSectionList>,
$ReadOnly<{
getListRef: () => ?React.ElementRef<typeof VirtualizedList>,
scrollToLocation: (params: ScrollToLocationParamsType) => void,
...
}>,
>);
module.exports = VirtualizedSectionList as component(
ref: React.RefSetter<
$ReadOnly<{
+getListRef: () => ?React.ElementRef<typeof VirtualizedList>,
+scrollToLocation: (params: ScrollToLocationParamsType) => void,
...
}>,
>,
...React.ElementConfig<typeof VirtualizedSectionList>
);