-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google-java-format to 1.23.0 #46860
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Oct 7, 2024
This pull request was exported from Phabricator. Differential Revision: D60787993 |
Summary: Pull Request resolved: facebook#46860 Pulling library into our repository Result of: arc artificer download com.google.googlejavaformat:google-java-format:1.23.0 --interactive Deps ``` ➜ arc artificer rquery dependencies --cross-reference com.google.googlejavaformat:google-java-format:1.23.0 com.google.googlejavaformat:google-java-format:1.23.0 ✅ └╼ com.google.guava:guava:32.1.3-jre:compile ✅ ``` Formatted with ``` tools/arcanist/lint/codemods/googlejavaformat_fbsource ``` Reviewed By: hick209 Differential Revision: D60787993
This pull request was exported from Phabricator. Differential Revision: D60787993 |
j-bahr
force-pushed
the
export-D60787993
branch
from
October 11, 2024 22:13
1c1e007
to
df14ab9
Compare
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Oct 12, 2024
Summary: X-link: facebook/react-native#46860 Pulling library into our repository Result of: arc artificer download com.google.googlejavaformat:google-java-format:1.23.0 --interactive Deps ``` ➜ arc artificer rquery dependencies --cross-reference com.google.googlejavaformat:google-java-format:1.23.0 com.google.googlejavaformat:google-java-format:1.23.0 ✅ └╼ com.google.guava:guava:32.1.3-jre:compile ✅ ``` Formatted with ``` tools/arcanist/lint/codemods/googlejavaformat_fbsource ``` Reviewed By: hick209 Differential Revision: D60787993 fbshipit-source-id: dbadc5184c0a7cccd967173e21602657013ddac7
This pull request has been merged in 9ba6237. |
This pull request was successfully merged by @j-bahr in 9ba6237 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/ktfmt
that referenced
this pull request
Oct 12, 2024
Summary: X-link: facebook/react-native#46860 Pulling library into our repository Result of: arc artificer download com.google.googlejavaformat:google-java-format:1.23.0 --interactive Deps ``` ➜ arc artificer rquery dependencies --cross-reference com.google.googlejavaformat:google-java-format:1.23.0 com.google.googlejavaformat:google-java-format:1.23.0 ✅ └╼ com.google.guava:guava:32.1.3-jre:compile ✅ ``` Formatted with ``` tools/arcanist/lint/codemods/googlejavaformat_fbsource ``` Reviewed By: hick209 Differential Revision: D60787993 fbshipit-source-id: dbadc5184c0a7cccd967173e21602657013ddac7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pulling library into our repository
Result of:
arc artificer download com.google.googlejavaformat:google-java-format:1.23.0 --interactive
Deps
Formatted with
Reviewed By: hick209
Differential Revision: D60787993