Fix onEndReached not being called when getItemLayout is present and we scroll past render window #46990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64222424 |
ChongYunPeng
pushed a commit
to ChongYunPeng/react-native
that referenced
this pull request
Oct 11, 2024
…e scroll past render window (facebook#46990) Summary: This is a reattempt land D63643856 to fix the scroll onendreached event not firing. Changelog: [General][Fixed] - Fix onEndReached not being called when getItemLayout is present and we scroll past render window Reviewed By: NickGerleman Differential Revision: D64222424
ChongYunPeng
force-pushed
the
export-D64222424
branch
from
95caf3f to
cedf1fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64222424 |
…e scroll past render window (facebook#46990) Summary: This is a reattempt land D63643856 to fix the scroll onendreached event not firing. Changelog: [General][Fixed] - Fix onEndReached not being called when getItemLayout is present and we scroll past render window Reviewed By: NickGerleman Differential Revision: D64222424
ChongYunPeng
force-pushed
the
export-D64222424
branch
from
cedf1fa to
d528e96
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64222424 |
|
This pull request has been merged in 3485e9e. |
|
This pull request was successfully merged by YunPeng Chong in 3485e9e When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a reattempt land D63643856 to fix the scroll onendreached event not firing.
Changelog:
[General][Fixed] - Fix onEndReached not being called when getItemLayout is present and we scroll past render window
Reviewed By: NickGerleman
Differential Revision: D64222424