Silence CMake warning caused by PROJECT_ROOT_DIR
#47015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: CMake is complaining that this variable is set outside the build but not used. I'm using it inside our top level .cmake file to silence this warning. We need this variable as user projects might use it. Changelog: [Internal] [Changed] - Silence CMake warning caused by `PROJECT_ROOT_DIR` Differential Revision: D64334462
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64334462 |
|
This pull request has been merged in 44c5cc3. |
|
This pull request was successfully merged by @cortinico in 44c5cc3 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
CMake is complaining that this variable is set outside the build but not used.
I'm using it inside our top level .cmake file to silence this warning.
We need this variable as user projects might use it.
Changelog:
[Internal] [Changed] - Silence CMake warning caused by
PROJECT_ROOT_DIRDifferential Revision: D64334462