Stable API - Make AccessibilityInfoModule internal
#47092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This class should not be public. I'm updating the BUCK rule to make it `internal` and remove it from the public API surface. Technically breaking however I haven't found meaningful usages of this API in OSS so this should be safe to ship. Changelog: [Android] [Breaking] - Make `AccessibilityInfoModule` internal Differential Revision: D64539866
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64539866 |
|
This pull request has been merged in 7168a9d. |
|
This pull request was successfully merged by @cortinico in 7168a9d When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This class should not be public. I'm updating the BUCK rule to make it
internaland remove it from the public API surface.Technically breaking however I haven't found meaningful usages of this API in OSS so this should be safe to ship.
Changelog:
[Android] [Breaking] - Make
AccessibilityInfoModuleinternalDifferential Revision: D64539866