earlyjs: Extend C++ pipeline for non-js errors #47529
Closed
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64626610 |
RSNara
force-pushed
the
export-D64626610
branch
from
eb72921
to
93eec8b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64626610 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Nov 11, 2024
) Summary: RuntimeExecutor, RuntimeScheduler, etc. can execute arbitrary c++ on the javascript thread. If that c++ throws a non-jsi::JSError, it will bypass the js error handler (and start tearing down the react instance 😱). Let's have the js error handler manage all exceptions raised while native is calling into js. This is more sane. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D64626610
Summary: RuntimeExecutor, RuntimeScheduler, etc. can execute arbitrary c++ on the javascript thread. If that c++ throws a non-jsi::JSError, it will bypass the js error handler (and start tearing down the react instance 😱). Let's have the js error handler manage all exceptions raised while native is calling into js. This is more sane. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D64626610
RSNara
force-pushed
the
export-D64626610
branch
from
93eec8b
to
cb9b3c4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64626610 |
|
This pull request has been merged in ca7b9e9. |
|
This pull request was successfully merged by @RSNara in ca7b9e9 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RuntimeExecutor, RuntimeScheduler, etc. can execute arbitrary c++ on the javascript thread.
If that c++ throws a non-jsi::JSError, it will bypass the js error handler (and start tearing down the react instance 😱).
Let's have the js error handler manage all exceptions raised while native is calling into js. This is more sane.
Changelog: [Internal]
Differential Revision: D64626610