Align HermesBadge to bottom to avoid overlap with status bar #47734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66183918 |
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Nov 20, 2024
…k#47734) Summary: - With forced edge-to-edge on Android 15 targetSdk 35, `HermesBadge` overlaps with the top status bar. - Move the location of the HermesBadge to align with bottom of the header so we can avoid UI overlap with minimal changes to the template. Changelog: [Internal] Differential Revision: D66183918
|
Changes applied on template generated app: Android API 35 iOS |
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Nov 20, 2024
…k#47734) Summary: - With forced edge-to-edge on Android 15 targetSdk 35, `HermesBadge` overlaps with the top status bar. - Move the location of the HermesBadge to align with bottom of the header so we can avoid UI overlap with minimal changes to the template. Changelog: [Internal] Differential Revision: D66183918
alanleedev
force-pushed
the
export-D66183918
branch
from
ad727aa to
4c660e5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66183918 |
Summary: NewAppScreen should be removed from public API test Changelog: [Internal] Differential Revision: D66165484
…k#47734) Summary: - With forced edge-to-edge on Android 15 targetSdk 35, `HermesBadge` overlaps with the top status bar. - Move the location of the HermesBadge to align with bottom of the header so we can avoid UI overlap with minimal changes to the template. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66183918
alanleedev
force-pushed
the
export-D66183918
branch
from
4c660e5 to
1641773
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66183918 |
|
This pull request has been merged in 7733c33. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
HermesBadgeoverlaps with the top status bar.Differential Revision: D66183918