Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update targetSdk to 35 #47738

Closed
wants to merge 3 commits into from
Closed

update targetSdk to 35 #47738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee3c374
Remove NewAppScreen from public API test (#47707)
alanleedev Nov 20, 2024
e3fec84
Align HermesBadge to bottom to avoid overlap with status bar (#47734)
alanleedev Nov 20, 2024
b3337fb
update targetSdk to 35
alanleedev Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/helloworld/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ buildscript {
buildToolsVersion = "35.0.0"
minSdkVersion = 24
compileSdkVersion = 35
targetSdkVersion = 34
targetSdkVersion = 35
ndkVersion = "27.1.12297006"
kotlinVersion = "2.0.21"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/NewAppScreen/components/HermesBadge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ const HermesBadge = (): Node => {
const styles = StyleSheet.create({
badge: {
position: 'absolute',
top: 8,
right: 12,
bottom: 8,
},
badgeText: {
fontSize: 14,
Expand Down
43 changes: 0 additions & 43 deletions packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6903,49 +6903,6 @@ exports[`public API should not change unintentionally Libraries/Network/fetch.js
"
`;

exports[`public API should not change unintentionally Libraries/NewAppScreen/components/Colors.js 1`] = `
"declare export default {
primary: \\"#1292B4\\",
white: \\"#FFF\\",
lighter: \\"#F3F3F3\\",
light: \\"#DAE1E7\\",
dark: \\"#444\\",
darker: \\"#222\\",
black: \\"#000\\",
};
"
`;

exports[`public API should not change unintentionally Libraries/NewAppScreen/components/DebugInstructions.js 1`] = `
"declare const DebugInstructions: () => Node;
declare export default typeof DebugInstructions;
"
`;

exports[`public API should not change unintentionally Libraries/NewAppScreen/components/Header.js 1`] = `
"declare const Header: () => Node;
declare export default typeof Header;
"
`;

exports[`public API should not change unintentionally Libraries/NewAppScreen/components/HermesBadge.js 1`] = `
"declare const HermesBadge: () => Node;
declare export default typeof HermesBadge;
"
`;

exports[`public API should not change unintentionally Libraries/NewAppScreen/components/LearnMoreLinks.js 1`] = `
"declare const LinkList: () => Node;
declare export default typeof LinkList;
"
`;

exports[`public API should not change unintentionally Libraries/NewAppScreen/components/ReloadInstructions.js 1`] = `
"declare const ReloadInstructions: () => Node;
declare export default typeof ReloadInstructions;
"
`;

exports[`public API should not change unintentionally Libraries/NewAppScreen/index.js 1`] = `
"export {
Colors,
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/Libraries/__tests__/public-api-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const IGNORE_PATTERNS = [
'**/*.fb.js',
'**/*.macos.js',
'**/*.windows.js',
'Libraries/NewAppScreen/components/**',
// Non source files
'Libraries/Renderer/implementations/**',
'Libraries/Renderer/shims/**',
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactAndroid/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
as the min SDK to lint the file.-->
<uses-sdk
android:minSdkVersion="24"
android:targetSdkVersion="34"
android:targetSdkVersion="35"
/>

</manifest>
2 changes: 1 addition & 1 deletion packages/react-native/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[versions]
# Android versions
minSdk = "24"
targetSdk = "34"
targetSdk = "35"
compileSdk = "35"
buildTools = "35.0.0"
ndkVersion = "27.1.12297006"
Expand Down
Loading