fix KeyboardAvoidingView infinite updates on android #48171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fix a regression from 1cea8e8 that would fix #47140 and potentially #47926 (comment)
the
keyboardDidHide
sent an incorrect screenY value. before 1cea8e8, the screenY is the size including system bar. after that change, it does not, becausegetWindowVisibleDisplayFrame()
does not include system bar size.this pr tries to align the screenX and screenY values as the
keyboardDidShow
event. we should use the same logic between show and hide.Changelog:
[ANDROID] [FIXED] - Fix KeyboardAvoidingView infinite updates on Android
Test Plan:
npx expo run:android
KeyboardAvoidingView
with translucent status bar leaves space at the bottom of the screen on Android #47140