Calculate Android mounting instructions based on updates accumulated in rawProps #48303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63457028 |
…in rawProps (facebook#48303) Summary: ## Context If a component is re-rendered/committed multiple times before mount, Android mounting layer creates and executes mounting instructions for every commit. Component's native representation is updated multiple times, potentially triggering expensive computations (e.g. recreating boxShadows) for a single draw. A more efficient way would be to create mounting instructions to update the component from the initial state (before the first render) to the final state (after the last render) in one go. iOS does that. This diff is an attempt to experiment on achieving such behaviour for Android. ## Implementation Details 1. When cloning a ShadowNode, accumulate all the updates in `Props.rawProps`. 2. For calculating prop update payloads to be sent to the Android mounting layer, diff old and new `rawProps` by calling `newProps->getDiffProps(oldProps)`. 3. Most importantly, move computing of the mounting instructions from `schedulerDidFinishTransaction`, which is called after every commit, to `schedulerShouldRenderTransactions` which happens only once, after the final commit. Changelog: [Internal] Reviewed By: javache Differential Revision: D63457028
dmytrorykun
force-pushed
the
export-D63457028
branch
from
64dd30c to
a444ece
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63457028 |
Contributor
|
This pull request has been merged in 0ceb0b3. |
Collaborator
|
This pull request was successfully merged by @dmytrorykun in 0ceb0b3 When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
If a component is re-rendered/committed multiple times before mount, Android mounting layer creates and executes mounting instructions for every commit. Component's native representation is updated multiple times, potentially triggering expensive computations (e.g. recreating boxShadows) for a single draw.
A more efficient way would be to create mounting instructions to update the component from the initial state (before the first render) to the final state (after the last render) in one go.
iOS does that.
This diff is an attempt to experiment on achieving such behaviour for Android.
Implementation Details
Props.rawProps.rawPropsby callingnewProps->getDiffProps(oldProps).schedulerDidFinishTransaction, which is called after every commit, toschedulerShouldRenderTransactionswhich happens only once, after the final commit.Changelog: [Internal]
Differential Revision: D63457028