-
Notifications
You must be signed in to change notification settings - Fork 25k
refactor: migrate DynamicFromMap to Kotlin #50597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate DynamicFromMap to Kotlin #50597
Conversation
|
Hi @artus9033! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
24425cd to
a86e394
Compare
mateoguzmana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left a few remarks we would need to check first.
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromMap.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromMap.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromMap.kt
Show resolved
Hide resolved
|
@mateoguzmana I applied the suggested changes and also decided to implement unit tests for |
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromMap.kt
Show resolved
Hide resolved
Thank you for the tests! it's a great addition, it's ok to leave them in this PR |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 86a7388. |
|
This pull request was successfully merged by @artus9033 in 86a7388 When will my fix make it into a release? | How to file a pick request? |
Summary: This PR introduces a rewrite of `DynamicFromMap.java` to Kotlin as requested in facebook#50513. ## Changelog: [ANDROID] [CHANGED] - Migrated `DynamicFromMap.java` to Kotlin Pull Request resolved: facebook#50597 Test Plan: 1. Implement unit tests for `DynamicFromMap.kt` - `DynamicFromMapTests.kt` 2. Ensure the tests pass: `./gradlew test` 3. Run the RN tester app on new & on old architectures Reviewed By: javache, rshest Differential Revision: D72853616 Pulled By: cortinico fbshipit-source-id: 855acdc7fa7810ab9f223b0be7778c028a646de5
Summary:
This PR introduces a rewrite of
DynamicFromMap.javato Kotlin as requested in #50513.Changelog:
[ANDROID] [CHANGED] - Migrated
DynamicFromMap.javato KotlinTest Plan:
DynamicFromMap.kt-DynamicFromMapTests.kt./gradlew test