Skip to content

Conversation

@artus9033
Copy link
Contributor

@artus9033 artus9033 commented Apr 9, 2025

Summary:

This PR introduces a rewrite of DynamicFromMap.java to Kotlin as requested in #50513.

Changelog:

[ANDROID] [CHANGED] - Migrated DynamicFromMap.java to Kotlin

Test Plan:

  1. Implement unit tests for DynamicFromMap.kt - DynamicFromMapTests.kt
  2. Ensure the tests pass: ./gradlew test
  3. Run the RN tester app on new & on old architectures

@facebook-github-bot
Copy link
Contributor

Hi @artus9033!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2025
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@artus9033 artus9033 force-pushed the refactor/dynamicfrommap-kotlin-rewrite branch from 24425cd to a86e394 Compare April 9, 2025 20:24
@artus9033 artus9033 marked this pull request as ready for review April 9, 2025 20:26
@mateoguzmana mateoguzmana self-requested a review April 9, 2025 21:14
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 9, 2025
Copy link
Collaborator

@mateoguzmana mateoguzmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left a few remarks we would need to check first.

@artus9033
Copy link
Contributor Author

artus9033 commented Apr 9, 2025

@mateoguzmana I applied the suggested changes and also decided to implement unit tests for DynamicFromMap. Would we be okay with introducing tests in this PR or is this a matter for a separate one?

@artus9033 artus9033 requested a review from mateoguzmana April 9, 2025 22:28
@mateoguzmana
Copy link
Collaborator

@mateoguzmana I applied the suggested changes and also decided to implement unit tests for DynamicFromMap. Would we be okay with introducing tests in this PR or is this a matter for a separate one?

Thank you for the tests! it's a great addition, it's ok to leave them in this PR

@mateoguzmana mateoguzmana requested a review from cortinico April 10, 2025 19:00
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 11, 2025
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 86a7388.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @artus9033 in 86a7388

When will my fix make it into a release? | How to file a pick request?

uffoltzl pushed a commit to uffoltzl/react-native that referenced this pull request Apr 18, 2025
Summary:
This PR introduces a rewrite of `DynamicFromMap.java` to Kotlin as requested in facebook#50513.

## Changelog:

[ANDROID] [CHANGED] - Migrated `DynamicFromMap.java` to Kotlin

Pull Request resolved: facebook#50597

Test Plan:
1. Implement unit tests for `DynamicFromMap.kt` - `DynamicFromMapTests.kt`
2. Ensure the tests pass: `./gradlew test`
3. Run the RN tester app on new & on old architectures

Reviewed By: javache, rshest

Differential Revision: D72853616

Pulled By: cortinico

fbshipit-source-id: 855acdc7fa7810ab9f223b0be7778c028a646de5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants