Minor Performance and Code Quality Improvements ✈️ #50682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
sanjaiyan-dev
changed the title
facebook-github-bot
added
the
Shared with Meta
|
Neat, thanks. |
|
@yungsters has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @sanjaiyan-dev in 38fefb2 When will my fix make it into a release? | How to file a pick request? |
|
@yungsters merged this pull request in 38fefb2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Hi,
I made a small update to the dependency array in
useLayoutEffect, changing it from[native]to[native.value]for better precision. Since JavaScript compares objects by reference, this change can lead to a minor performance improvement. Additionally, asuseLayoutEffectis render-blocking, I wanted to ensure we optimize its usage as much as possible.As a micro-optimization and in line with good coding practices, I also changed a
let + ifvariable toconst. While the performance gain is minimal, it contributes to cleaner and more consistent code.Please feel free to review, and I sincerely apologize if I made any mistakes in the process.
Changelog:
[General] [Changed] – Refined
useLayoutEffectdependency array from[native]to[native.value]for improved precision and efficiency in re-renders.[General] [Changed] – Replaced
letwithconstwhere applicable for better code standards and micro-optimization.Test Plan: