[Pod] Preserve header directory structure #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brilliant! I was having some trouble with the podspec over the weekend but I'm glad someone figured it out. I'll check this out tomorrow (it's getting late here in London) and we can merge this in. Thanks a bunch! 😅 |
|
On a related note I was thinking it could be good to include 'pod install' as part of the integration tests especially if not a lot of people at facebook are actively using the podspec. |
|
Looking at this now. |
The React code has relative imports like `#import "../React/Base/Layout.h"`. CocoaPods by default flattens the header files so they're all in a single directory, but specifying `header_mappings_dir` in the podspec preserves the directory structure.
|
Committed in 18cb5d0. |
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 13, 2015
Summary: The React code has relative imports like `#import "../React/Base/Layout.h"`. CocoaPods by default flattens the header files so they're all in a single directory, but specifying `header_mappings_dir` in the podspec preserves the directory structure. Closes facebook#508 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
Summary: The React code has relative imports like `#import "../React/Base/Layout.h"`. CocoaPods by default flattens the header files so they're all in a single directory, but specifying `header_mappings_dir` in the podspec preserves the directory structure. Closes facebook#508 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
Summary: The React code has relative imports like `#import "../React/Base/Layout.h"`. CocoaPods by default flattens the header files so they're all in a single directory, but specifying `header_mappings_dir` in the podspec preserves the directory structure. Closes facebook#508 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2017
Summary: Just cherry-picked my commit from #508 Closes facebook/yoga#542 Differential Revision: D5002335 Pulled By: emilsjolander fbshipit-source-id: 3f61a235c41627e9cfb90dce150323f11892e65f
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this pull request
May 7, 2017
Summary: Just cherry-picked my commit from facebook#508 Closes facebook/yoga#542 Differential Revision: D5002335 Pulled By: emilsjolander fbshipit-source-id: 3f61a235c41627e9cfb90dce150323f11892e65f
makadaw
pushed a commit
to makadaw/react-native
that referenced
this pull request
May 9, 2017
Summary: Just cherry-picked my commit from facebook#508 Closes facebook/yoga#542 Differential Revision: D5002335 Pulled By: emilsjolander fbshipit-source-id: 3f61a235c41627e9cfb90dce150323f11892e65f
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
accessibilityIgnoresInvertColors was incorrectly a H3 when it should be a H4 for consistency.
mganandraj
added a commit
to mganandraj/react-native
that referenced
this pull request
Jul 29, 2020
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 28, 2022
Summary: I'm not going to merge this as it is, this is mostly for discussions with the community for the sake of RFC facebook#508 react-native-community/discussions-and-proposals#508 Here I'm setting up a :ReactAndroid:external-artifacts Gradle module which is responsible of uploading arbitrary artifacts to Maven (Central or any other repo). In this specific example I'm uploading the Hermes iOS tarball which is 500+ Mb. In this module I've configured the auth with Sonatype for publishing and the GPG signing of the artifacts. Changelog: [Internal] [Changed] - Store the iOS Hermes tarball on Maven Differential Revision: D39886167 fbshipit-source-id: 66edae7f83df35525dc8cccd68bb5bb3a5e02a12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The React code has relative imports like
#import "../React/Base/Layout.h". CocoaPods by default flattens the header files so they're all in a single directory, but specifyingheader_mappings_dirin the podspec preserves the directory structure.