Added Hyper-V Android Emulator Setup Instructions. Closes #3234 #5117
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
|
||
| To use it with react-native you just have to add a key and value to your registry: | ||
|
|
||
| HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Android SDK Tools |
There was a problem hiding this comment.
Can you wrap it in backticks? like
```
HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Android SDK Tools
```
|
Thanks for the PR. Let's fix these few thinsg before merging. @mkonicek What about the assets? Where should we upload them? |
satya164
changed the title
|
@BerndWessels updated the pull request. |
|
@satya164 I've updated based on your feedback. Not sure if the screenshot is actually needed. |
|
Thanks! Assets should be uploaded to {RN_REPO_ROOT}/website/src/react-native/img |
|
|
||
| A lot of developers, especially in the enterprise space are using Hyper-V on their machines. Unfortunately the default Android Emulator cannot be hardware accelerated if Hyper-V is turned on and turning it off is often not an option. | ||
|
|
||
| Fortunately there is a great and free android emulator that uses Hyper-V. |
There was a problem hiding this comment.
Can you remove this line? We already say these things in the paragraph below.
|
Thanks @astreet @BerndWessels Can you add the image to the location @astreet suggested before we can merge ? |
|
@BerndWessels updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@satya164 I removed the lines you mentioned and also the screenshot since the documentation now explains all the steps in detail. |
|
@BerndWessels Thanks. Looks good. Can you squash the commits to one before we merge? |
|
|
||
| The [Visual Studio Emulator for Android](https://www.visualstudio.com/en-us/features/msft-android-emulator-vs.aspx) is a free android emulator that is hardware accelerated via Hyper-V. It doesn't require you to install Visual Studio at all. | ||
|
|
||
| It is free, very powerful, fast and hardware accelerated via Hyper-V technology. |
There was a problem hiding this comment.
Okay, missed this one. We basically say the same things in the previous paragraph. So remove this also.
|
@satya164 oops, how do I do that (the git squashing thing)? |
|
@satya164 I hope the squashing worked, the text should be fine now and the screenshot is removed. |
|
@BerndWessels Nope. There are still 5 commits. |
|
Also, you didn't remove the line I mentioned. :( |
|
@satya164 OK, so this should be the text, right? Or which line do you mean? Windows Hyper-V AlternativeThe Visual Studio Emulator for Android is a free android emulator that is hardware accelerated via Hyper-V. It doesn't require you to install Visual Studio at all. To use it with react-native you just have to add a key and value to your registry:
You will also need to run the command Then restart the emulator and when it runs you can just do |
|
Yup. |
|
@BerndWessels updated the pull request. |
|
@satya164 Sorry I doubt I get the commits squashed together since I made them in the master of my fork rather than in a branch - at least I can't find anyway to achieve that. If all this is too much trouble I can just create a new pull request or you make your own based on whats here. Sorry for the trouble - I sometimes struggle with Git. |
|
@BerndWessels No problem. Branch shouldn't make a difference. You can alternatively run the following, git reset --soft HEAD~6
git commit -m "Added Hyper-V Android Emulator Setup Instructions. Closes #3234"
git push -fIf it doesn't work. Feel free to send another PR and tag me. |
|
@BerndWessels updated the pull request. |
|
@satya164 ok, I did the git commands, now there is only one commit but I think there is other stuff in it now that does not belong to it. |
|
Ouch. Just do a new PR. Fixing is too much work. Sorry for the trouble. |
|
Thanks for adding this! |
|
@BerndWessels Any updates on this? |
These are the instructions to use a Hyper-V hardware accelerated Android emulator on Windows.