fix: pressability issues new arch

[hannojg]

Summary:

Addresses: #51621

Fixes press ability issues on new arch by adding a separate path for measuring, called:

• measureAsyncOnUI

this method will call into the platform MountingManager implementations to measure using just the native view hierarchy.
This way the measurement should always be correct.

Note: the method for measuring is basically copied over from old arch code.

Changelog:

[GENERAL] [FIXED] Pressability issues on new arch

Test Plan:

• Test press ability section in rn-tester
• Run this code example in the playground on main VS on these diffs to verify that press ability during animation works now: https://github.com/hannojg/rn-animated-pressability/blob/main/ReproducerApp/App.tsx

[Hardanish-Singh]

LGTM!

[klxiaoniu]

Any updates on this?

[oleksandr-dziuban]

Hello guys, can this fix be cherry-picked into v0.80.x, for example ?

[Dallas62]

Will also check if this resolve #53366 in next hours.

EDIT:
Maybe I'm testing it not the right way, but I always face this:

[SzyVsSi]

Any alternative solutions while we wait for this PR to be merged?

[Bowlerr]

👀

[joacub]

when is this going to be merged ?

[just-myself]

Any updates on this?

[hannojg]

Let me update this PR today or tmrw so there are no merge conflicts and it works with the latest main, then we can maybe move it forward!

[react-native-bot]

	Warnings
⚠️	❗ JavaScript API change detected - This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API. Please include a clear changelog message. This change will be subject to extra review. This change was flagged as: BREAKING

Generated by 🚫 dangerJS against 7f2df56

[hannojg]

Hey, I rewrote this PR to be mergable against main.
The main change here was that we need to call through the NativeDOM module. I added the new measureAsyncOnUI method there, can we please double check whether this is the correct place for it?
Alternatively we could call to the fabric ui manager, but it seems to me we want to avoid that in NativeDOM ?

Kindly requesting another round of review @Hardanish-Singh
Will also ping maintainers on discord!

---

For folks needing this fix for older RN versions, I kept a copy of the old branch targeting RN 0.79 here:

• main...hannojg:react-native:fix/pressability-issues-by-measuring-native-view-hierarchy-rn-079

[cipolleschi]

This change is kind of big and touches multiple parts of React Native.
I strongly suggest to wrap it within a feature flag so we can easily switch back to the old behavior in case it misbehave in prod in our apps.

ideally, it would be better if you can split it in smaller pieces, but perhaps it is easier to review as a whole for an approval and then we can split it.

I don't have the full picture on this, so I'll forward to somebody in the team that can provide a good review.

[hannojg]

Thanks for the first quick check! Let me add a feature flag first. The feature flag could gate this call in

packages/react-native/Libraries/Pressability/Pressability.js:

    if (typeof this._responderID === 'number') {
      UIManager.measure(this._responderID, this._measureCallback);
    } else {
-      this._responderID.measure(this._measureCallback);
+      this._responderID.measureAsyncOnUI(this._measureCallback);
    }
  }

Putting the native code behind a feature flag would be a bit difficult since we touch turbo module specs.

Adding a new virtual method to the scheduler kind of trickles down into all those places touched here, so it would be a bit hard to split the PR up otherwise.

[Dallas62]

Hi @cipolleschi,

It would be great if someone from Meta could take a look to all pressability issues in new arch or try to implement the requested feature flag.

It's a bug present and reported multiples time from months now...

[lodev09]

The Pressable onPress issue is breaking TrueSheet nesting capabilities 😢. Hopefully this gets merged soon! 🙏