-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[LOCAL][RN][Release] Fix E2E test script when the ci flag is not specified #52609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62cd4bd to
d46e709
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 15, 2025
Summary: The `test-release-local` script was failing to execute the npx rreact-native run-ios command for some issues with cocoapods. That command tries to reinstall the pods so there might be some issues when testing. As an alternative, we can avoid duplicated work by dropping the npx react-native command and, instead, build the app with xcodebuild and install it in the simulator with xcrun. This is a backport of [this PR](facebook#52609) ## Changelog: [Internal] - Differential Revision: D78344397
d46e709 to
a81f6be
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 15, 2025
Summary: The `test-release-local` script was failing to execute the npx rreact-native run-ios command for some issues with cocoapods. That command tries to reinstall the pods so there might be some issues when testing. As an alternative, we can avoid duplicated work by dropping the npx react-native command and, instead, build the app with xcodebuild and install it in the simulator with xcrun. This is a backport of [this PR](facebook#52609) ## Changelog: [Internal] - Reviewed By: vzaidman Differential Revision: D78344397
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 15, 2025
Summary: The `test-release-local` script was failing to execute the npx rreact-native run-ios command for some issues with cocoapods. That command tries to reinstall the pods so there might be some issues when testing. As an alternative, we can avoid duplicated work by dropping the npx react-native command and, instead, build the app with xcodebuild and install it in the simulator with xcrun. This is a backport of [this PR](facebook#52609) ## Changelog: [Internal] - Reviewed By: vzaidman Differential Revision: D78344397
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Summary: Pull Request resolved: #52617 The `test-release-local` script was failing to execute the npx rreact-native run-ios command for some issues with cocoapods. That command tries to reinstall the pods so there might be some issues when testing. As an alternative, we can avoid duplicated work by dropping the npx react-native command and, instead, build the app with xcodebuild and install it in the simulator with xcrun. This is a backport of [this PR](#52609) ## Changelog: [Internal] - Reviewed By: vzaidman Differential Revision: D78344397 fbshipit-source-id: cf2d9c032966a9be05670259e9532789829349f2
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: facebook#52617 The `test-release-local` script was failing to execute the npx rreact-native run-ios command for some issues with cocoapods. That command tries to reinstall the pods so there might be some issues when testing. As an alternative, we can avoid duplicated work by dropping the npx react-native command and, instead, build the app with xcodebuild and install it in the simulator with xcrun. This is a backport of [this PR](facebook#52609) ## Changelog: [Internal] - Reviewed By: vzaidman Differential Revision: D78344397 fbshipit-source-id: cf2d9c032966a9be05670259e9532789829349f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
Pick Request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
THe test-e2e-local script was failing to execute the
npx rreact-native run-ioscommand for some issues with cocoapods.That command tries to reinstall the pods so there might be some issues when testing.
As an alternative, we can avoid duplicated work by dropping the
npx react-nativecommand and, instead, build the app withxcodebuildand install it in the simulator withxcrun.Changelog:
[Internal] -
Test Plan:
Tested locally by running