Add support for details field and custom tracks in performance.mark and performance.measure for DevTools #52613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78340911 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78340911 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 15, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Pull Request resolved: facebook#52613 Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
force-pushed
the
export-D78340911
branch
from
093e3d6 to
643941a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78340911 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 15, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Pull Request resolved: facebook#52613 Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
force-pushed
the
export-D78340911
branch
from
643941a to
ffd8b16
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78340911 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 15, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Pull Request resolved: facebook#52613 Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
force-pushed
the
export-D78340911
branch
from
ffd8b16 to
7aa1d6e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78340911 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 15, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Pull Request resolved: facebook#52613 Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
force-pushed
the
export-D78340911
branch
2 times, most recently
from
2a3f653 to
870120e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78340911 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
force-pushed
the
export-D78340911
branch
from
870120e to
6ed110e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78340911 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
… the "Track:" prefix (facebook#52614) Summary: Changelog: [internal] We're adding first-class support for custom tracks, so we can remove the legacy mechanism to specify tracks with the "Tracks:" prefix in the event names. Reviewed By: sbuggay Differential Revision: D78340910
…nd performance.measure for DevTools (facebook#52613) Summary: Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911
rubennorte
force-pushed
the
export-D78340911
branch
from
6ed110e to
ed55521
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78340911 |
Contributor
|
This pull request has been merged in bd19832. |
ghost
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 29, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Pull Request resolved: facebook#52613 Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911 fbshipit-source-id: 383dd1cb6fcc8a04be9e65038503986f196e23c9
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
…nd performance.measure for DevTools (facebook#52613) Summary: Pull Request resolved: facebook#52613 Changelog: [internal] This adds first-class support for the `detail` field in `performance.mark` and `performance.measure`. Now that we have access the JS entry in native, we can access the `detail` field to propagate it to DevTools (and use it to extract track names for Perfetto). In order to avoid the performance overhead of always having to extract the `detail` field from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto. Reviewed By: sbuggay Differential Revision: D78340911 fbshipit-source-id: 383dd1cb6fcc8a04be9e65038503986f196e23c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This adds first-class support for the
detailfield inperformance.markandperformance.measure.Now that we have access the JS entry in native, we can access the
detailfield to propagate it to DevTools (and use it to extract track names for Perfetto).In order to avoid the performance overhead of always having to extract the
detailfield from the entry, this is done lazily only if we're actively profiling with DevTools or Perfetto.Reviewed By: sbuggay
Differential Revision: D78340911