Skip to content

Fix CQS signal readability-braces-around-statements in xplat/js/react-native-github/packages #52699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix CQS signal readability-braces-around-statements in xplat/js/react-native-github/packages #52699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-native/Libraries/FBLazyVector/FBLazyVector/FBLazyVector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,9 @@ class LazyVector {

const_reference at(size_type pos) const {
#ifndef _LIBCPP_NO_EXCEPTIONS
if (!(pos < _size))
if (!(pos < _size)) {
throw std::out_of_range("out of range");
}
#else
assert(pos < _size || !"out of range");
#endif
Expand Down
9 changes: 6 additions & 3 deletions packages/react-native/Libraries/Image/RCTUIImageViewAnimated.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ static NSUInteger RCTDeviceFreeMemory(void)
kern_return_t kern;

kern = host_page_size(host_port, &page_size);
if (kern != KERN_SUCCESS)
if (kern != KERN_SUCCESS) {
return 0;
}
kern = host_statistics(host_port, HOST_VM_INFO, (host_info_t)&vm_stat, &host_size);
if (kern != KERN_SUCCESS)
if (kern != KERN_SUCCESS) {
return 0;
}
return (vm_stat.free_count - vm_stat.speculative_count) * page_size;
}

Expand Down Expand Up @@ -278,8 +280,9 @@ - (void)displayDidRefresh:(CADisplayLink *)displayLink
- (void)calculateMaxBufferCount
{
NSUInteger bytes = CGImageGetBytesPerRow(self.currentFrame.CGImage) * CGImageGetHeight(self.currentFrame.CGImage);
if (bytes == 0)
if (bytes == 0) {
bytes = 1024;
}

NSUInteger max = 0;
if (self.maxBufferSize > 0) {
Expand Down
6 changes: 4 additions & 2 deletions packages/react-native/React/Views/RefreshControl/RCTRefreshControl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,9 @@ - (void)didMoveToWindow

- (void)beginRefreshingProgrammatically
{
if (!_hasMovedToWindow)
if (!_hasMovedToWindow) {
return;
}

UInt64 beginRefreshingTimestamp = _currentRefreshingStateTimestamp;
_refreshingProgrammatically = YES;
Expand Down Expand Up @@ -108,8 +109,9 @@ - (void)beginRefreshingProgrammatically

- (void)endRefreshingProgrammatically
{
if (!_hasMovedToWindow)
if (!_hasMovedToWindow) {
return;
}
// The contentOffset of the scrollview MUST be greater than the contentInset before calling
// endRefreshing otherwise the next pull to refresh will not work properly.
UIScrollView *scrollView = self.scrollView;
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native/ReactCommon/cxxreact/tests/jsbigstring.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ using namespace facebook::react;
namespace {
int tempFileFromString(std::string contents) {
const char* tmpDir = getenv("TMPDIR");
if (tmpDir == nullptr)
if (tmpDir == nullptr) {
tmpDir = "/tmp";
}
std::string tmp{tmpDir};
tmp += "/temp.XXXXXX";

Expand Down
Loading