RNGP - Make sure the newArchEnabled is set to true for all the libs #53138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Without this patch, library could break if the user removes the `newArchEnabled=` property from the `gradle.properties` file. With this patch instead we hardcode the property to true, so all the libraries can consume it if they wish. Changelog: [Internal] [Changed] - Differential Revision: D79805857
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79805857 |
5 tasks
Contributor
|
This pull request has been merged in ba518bb. |
Collaborator
|
This pull request was successfully merged by @cortinico in ba518bb When will my fix make it into a release? | How to file a pick request? |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
…acebook#53138) Summary: Pull Request resolved: facebook#53138 Without this patch, library could break if the user removes the `newArchEnabled=` property from the `gradle.properties` file. With this patch instead we hardcode the property to true, so all the libraries can consume it if they wish. Changelog: [Internal] [Changed] - Reviewed By: cipolleschi Differential Revision: D79805857 fbshipit-source-id: 88dda707a0d80ac79e96c955ded2ef0823f3d3ff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Without this patch, library could break if the user removes the
newArchEnabled=property from the
gradle.propertiesfile.With this patch instead we hardcode the property to true, so all the libraries can consume
it if they wish.
Changelog:
[Internal] [Changed] -
Differential Revision: D79805857