Fix a crash in RCTAsyncLocalStorage when the value is not a string. #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged internally and sync'd |
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 13, 2015
Summary: When you forget to pass the value parameter to AsyncStorage.setItem the entire app would crash instead of showing a useful error message. The problem was that the error function used in the file expected a dictionary but was passed the value of the key which caused the crash. Closes facebook#535 Github Author: Janic Duplessis <janicduplessis@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
Summary: When you forget to pass the value parameter to AsyncStorage.setItem the entire app would crash instead of showing a useful error message. The problem was that the error function used in the file expected a dictionary but was passed the value of the key which caused the crash. Closes facebook#535 Github Author: Janic Duplessis <janicduplessis@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
Summary: When you forget to pass the value parameter to AsyncStorage.setItem the entire app would crash instead of showing a useful error message. The problem was that the error function used in the file expected a dictionary but was passed the value of the key which caused the crash. Closes facebook#535 Github Author: Janic Duplessis <janicduplessis@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
To avoid brutal breaking change, I used `[@deprecated]` for pt. We can remove it a bit later, because we know some people rely on this bindings already :) Closes facebook#530
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
"accessibleComponentType" => "accessibilityComponentType" This is on `CustomRadioButton` so it's not technically wrong, but I would presume a component that eventually renders a `View` with `accessibilityComponentType` would use that name in its own API.
Corey-Peyton
added a commit
to Corey-Peyton/async-storage
that referenced
this pull request
Jul 14, 2021
Summary: When you forget to pass the value parameter to AsyncStorage.setItem the entire app would crash instead of showing a useful error message. The problem was that the error function used in the file expected a dictionary but was passed the value of the key which caused the crash. Closes facebook/react-native#535 Github Author: Janic Duplessis <janicduplessis@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
This was referenced Sep 12, 2021
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you forget to pass the value parameter to AsyncStorage.setItem the entire app would crash instead of showing a useful error message. The problem was that the error function used in the file expected a dictionary but was passed the value of the key which caused the crash.