Skip to content

[iOS] Replace execSync with spawnSync for tarball extraction paths that need to be escaped #53540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+12 −6
Closed

[iOS] Replace execSync with spawnSync for tarball extraction paths that need to be escaped #53540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/react-native/scripts/replace-rncore-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

'use strict';

const {execSync} = require('child_process');
const {spawnSync} = require('child_process');
const fs = require('fs');
const yargs = require('yargs');

Expand Down Expand Up @@ -67,7 +67,9 @@ function replaceRNCoreConfiguration(
fs.mkdirSync(finalLocation, {recursive: true});

console.log('Extracting the tarball', tarballURLPath);
execSync(`tar -xf ${tarballURLPath} -C ${finalLocation}`);
spawnSync('tar', ['-xf', tarballURLPath, '-C', finalLocation], {
stdio: 'inherit',
});
}

function updateLastBuildConfiguration(configuration /*: string */) {
Expand Down
6 changes: 4 additions & 2 deletions packages/react-native/sdks/hermes-engine/utils/replace_hermes_version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

'use strict';

const {execSync} = require('child_process');
const {spawnSync} = require('child_process');
const fs = require('fs');
const yargs = require('yargs');

Expand Down Expand Up @@ -62,7 +62,9 @@ function replaceHermesConfiguration(configuration, version, podsRoot) {
fs.mkdirSync(finalLocation, {recursive: true});

console.log('Extracting the tarball');
execSync(`tar -xf ${tarballURLPath} -C ${finalLocation}`);
spawnSync('tar', ['-xf', tarballURLPath, '-C', finalLocation], {
stdio: 'inherit',
});
}

function updateLastBuildConfiguration(configuration) {
Expand Down
6 changes: 4 additions & 2 deletions packages/react-native/third-party-podspecs/replace_dependencies_version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

'use strict';

const {execSync} = require('child_process');
const {spawnSync} = require('child_process');
const fs = require('fs');
const yargs = require('yargs');

Expand Down Expand Up @@ -66,7 +66,9 @@ function replaceRNDepsConfiguration(
fs.mkdirSync(finalLocation, {recursive: true});

console.log('Extracting the tarball', tarballURLPath);
execSync(`tar -xf ${tarballURLPath} -C ${finalLocation}`);
spawnSync('tar', ['-xf', tarballURLPath, '-C', finalLocation], {
stdio: 'inherit',
});

// Now we need to remove the extra third-party folder as we do in the podspec's prepare-script
// We need to take the ReactNativeDependencies.xcframework folder and move it up one level
Expand Down
Loading