[precompile][ios] fixed cp command to work with gnu coreutils #54063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using gnu coreutils, installation of ReactNativeDependenices on iOS fails at compile time with errors like in the following issue (in the Expo repo): expo/expo#38992 This is caused by a missing `.` in the end of the path name that the built-in MacOS cp command handles well, but that will create an extra Headers folder when using cp from gnu coreutils. This commit fixes this by adding the missing `.`
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
I was losing hope, but you saved the day. Indeed, GNU utils were the issue. I've tried everything to fix Expo 54 not working on my macOS (as in #22703 (comment) and expo/expo#38992) and coreutils were the culprit. For anyone wondering what I did:
rm -rf ios/Pods
rm -rf ios/Podfile.lock
rm -rf ios/build
rm -rf ~/Library/Developer/Xcode/DerivedData
rm -rf ~/Library/Caches/CocoaPods/
rm -rf ~/.cocoapods/
pod cache clean --all |
Collaborator
|
This pull request was successfully merged by @chrfalch in 068ec39 When will my fix make it into a release? | How to file a pick request? |
Contributor
Contributor
|
Thanks for fixing this @chrfalch 🙏 |
react-native-bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
Summary: When using gnu coreutils, installation of ReactNativeDependenices on iOS fails at compile time with errors like in the following issue (in the Expo repo): expo/expo#38992 This is caused by a missing `.` in the end of the path name that the built-in MacOS cp command handles well, but that will create an extra Headers folder when using cp from gnu coreutils. This commit fixes this by adding the missing `.` ## Changelog: [IOS] [FIXED] - Fixed issue when using gnu coreutils cp command when using precompiled binaries causing compilation error Pull Request resolved: #54063 Test Plan: - Verify that you're running gnu coreutils (`cp --version`) - Create new expo app `npx create-expo-app` - Build on iOS - should error without this fix, should work with the fix. Reviewed By: christophpurrer Differential Revision: D83964083 Pulled By: javache fbshipit-source-id: 46dc074ca9b7fc97fa5a37ef48d68a895e3310ff
Collaborator
|
This pull request was successfully merged by @chrfalch in 779c768 When will my fix make it into a release? | How to file a pick request? |
alanjhughes
pushed a commit
that referenced
this pull request
Oct 20, 2025
Summary: When using gnu coreutils, installation of ReactNativeDependenices on iOS fails at compile time with errors like in the following issue (in the Expo repo): expo/expo#38992 This is caused by a missing `.` in the end of the path name that the built-in MacOS cp command handles well, but that will create an extra Headers folder when using cp from gnu coreutils. This commit fixes this by adding the missing `.` ## Changelog: [IOS] [FIXED] - Fixed issue when using gnu coreutils cp command when using precompiled binaries causing compilation error Pull Request resolved: #54063 Test Plan: - Verify that you're running gnu coreutils (`cp --version`) - Create new expo app `npx create-expo-app` - Build on iOS - should error without this fix, should work with the fix. Reviewed By: christophpurrer Differential Revision: D83964083 Pulled By: javache fbshipit-source-id: 46dc074ca9b7fc97fa5a37ef48d68a895e3310ff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When using gnu coreutils, installation of ReactNativeDependenices on iOS fails at compile time with errors like in the following issue (in the Expo repo):
expo/expo#38992
This is caused by a missing
.in the end of the path name that the built-in MacOS cp command handles well, but that will create an extra Headers folder when using cp from gnu coreutils.This commit fixes this by adding the missing
.Changelog:
[IOS] [FIXED] - Fixed issue when using gnu coreutils cp command when using precompiled binaries causing compilation error
Test Plan:
cp --version)npx create-expo-app