[iOS][Fixed][LegacyArch] Fixed Switch component for Legacy Arch #54155
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
Thank you! That solved our issue 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The switch component got broken on Legacy Arch after #53067. That's because the React runtime does not know anymore how big are the switches.
On the new arch, we implemented a way for the native platform to inform React about the switch size, but we forgot to implement the same mechanism in the Legacy Arch.
React Native 0.81 has to support the Legacy Arch anyway, so this PR implements the same mechanism to inform React about the size of the Switch when running on the legacy arch.
This should fix #53537
Changelog:
[iOS][Fixed] - Fix Switches on the legacy arch
Test Plan:
Tested on RNTester, running the legacy arch.