Forward ACTION_SCROLL events to SwipeRefreshLayout children #55097
+190
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90209679. |
meta-cla
bot
added
the
CLA Signed
Abbondanzo
force-pushed
the
export-D90209679
branch
from
b9453f7 to
0b428cb
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jan 13, 2026
…#55097) Summary: This change adds support for joystick and scrollwheel input devices to trigger pull-to-refresh in SwipeRefreshLayout. Previously, `ACTION_SCROLL` events from non-touch input devices (joysticks, scrollwheels, etc.) were not being forwarded to child views wrapped in a SwipeRefreshLayout. This prevented child ScrollViews from receiving these events and handling pull-to-refresh gestures via nested scrolling. The fix overrides `dispatchGenericMotionEvent` in ReactSwipeRefreshLayout to explicitly forward `ACTION_SCROLL` events to the first child view before falling back to the default behavior. This allows child views to process the scroll events and communicate with the SwipeRefreshLayout parent through the standard nested scrolling APIs. Changelog: [Internal] Differential Revision: D90209679
…#55097) Summary: Pull Request resolved: facebook#55097 This change adds support for joystick and scrollwheel input devices to trigger pull-to-refresh in SwipeRefreshLayout. Previously, `ACTION_SCROLL` events from non-touch input devices (joysticks, scrollwheels, etc.) were not being forwarded to child views wrapped in a SwipeRefreshLayout. This prevented child ScrollViews from receiving these events and handling pull-to-refresh gestures via nested scrolling. The fix overrides `dispatchGenericMotionEvent` in ReactSwipeRefreshLayout to explicitly forward `ACTION_SCROLL` events to the first child view before falling back to the default behavior. This allows child views to process the scroll events and communicate with the SwipeRefreshLayout parent through the standard nested scrolling APIs. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D90209679
Abbondanzo
force-pushed
the
export-D90209679
branch
from
0b428cb to
d2a8181
Compare
|
This pull request has been merged in 77779f8. |
Collaborator
|
This pull request was successfully merged by @Abbondanzo in 77779f8 When will my fix make it into a release? | How to file a pick request? |
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jan 15, 2026
Summary: Reverts facebook#55097 Original Phabricator Diff: D90209679 Reverting this behavior and feature flag as the experiment that used it is no longer needed Changelog: [Internal] Differential Revision: D90791564
meta-codesync bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
#55194) Summary: Pull Request resolved: #55194 Reverts #55097 Original Phabricator Diff: D90209679 Reverting this behavior and feature flag as the experiment that used it is no longer needed Changelog: [Internal] Reviewed By: cortinico Differential Revision: D90791564 fbshipit-source-id: 362399c435a0c5addba5734e333bc2c1747f7293
Contributor
|
This pull request has been reverted by 03b1bf6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds support for joystick and scrollwheel input devices to trigger pull-to-refresh in SwipeRefreshLayout.
Previously,
ACTION_SCROLLevents from non-touch input devices (joysticks, scrollwheels, etc.) were not being forwarded to child views wrapped in a SwipeRefreshLayout. This prevented child ScrollViews from receiving these events and handling pull-to-refresh gestures via nested scrolling.The fix overrides
dispatchGenericMotionEventin ReactSwipeRefreshLayout to explicitly forwardACTION_SCROLLevents to the first child view before falling back to the default behavior. This allows child views to process the scroll events and communicate with the SwipeRefreshLayout parent through the standard nested scrolling APIs.Changelog: [Internal]
Differential Revision: D90209679