Skip bundling for Simulator #5519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Very cool, this speeds up the build a lot! @facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1722825984614727/int_phab to review. |
10 tasks
|
💯 |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1722825984614727/int_phab to review. |
|
Failed because of an unrelated issue in the CI :( |
ghost
closed this
in
mkonicek
pushed a commit
that referenced
this pull request
Jan 29, 2016
Summary: Following up on the conversation in https://www.prod.facebook.com/groups/reactnativeoss/permalink/1516993445263951/ I currently don't see any good reason to create an offline bundle for simulator builds. Closes #5519 Reviewed By: svcscm Differential Revision: D2859751 Pulled By: mkonicek fb-gh-sync-id: f70481e447e258f5531de773729fc31d9ebec6f7
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary: Following up on the conversation in https://www.prod.facebook.com/groups/reactnativeoss/permalink/1516993445263951/ I currently don't see any good reason to create an offline bundle for simulator builds. Closes facebook/react-native#5519 Reviewed By: svcscm Differential Revision: D2859751 Pulled By: mkonicek fb-gh-sync-id: f70481e447e258f5531de773729fc31d9ebec6f7
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the conversation in https://www.prod.facebook.com/groups/reactnativeoss/permalink/1516993445263951/ I currently don't see any good reason to create an offline bundle for simulator builds.
Test Plan: forced
react-native-clito point to my local installation,react-native init, Cmd+B in Xcode for iPhone Simulator – script was skipped, Cmd+B for iOS Device – script was executed.