-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navigator.getCurrentRoutes #553
Conversation
So, I've thought about this, and I am concerned because this navState will sometimes appear to be incorrect in the renderScene prop. Here's the simplest example:
I think this would probably add more confusion. Instead, I want to add a method to Navigator that lets you get the current routeStack. Is there a reason you need to access the routeStack from inside the navigator? Maybe I could show you where you might run into some issues and help you find an alternative. cc @ide , we were talking about this earlier |
@ericvicenti Thanks for your feedback! Yeah, I have a use-case for that: for example, I created a navbar component I wanna use with Navigator. As far as I'm not sure how |
I don't want to pollute renderScene's arguments. Thanks for adding it to the navigator! This looks good, I'll start merging this in. We can come back to the navBar ordering issue later. Absolute positioning of the navBar is OK because it needs to appear over the scenes in most cases. You shouldn't need to apply |
Is it going to be merged some day? |
Summary: According to our talk with @ericvicenti about `renderScene` arguments Closes facebook#553 Github Author: Kureev Alexey <kureev-mail@ya.ru> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: According to our talk with @ericvicenti about `renderScene` arguments Closes facebook#553 Github Author: Kureev Alexey <kureev-mail@ya.ru> Test Plan: Imported from GitHub, without a `Test Plan:` line.
* Promote 0.57 to stable and add back out-of-tree-platforms * Prettier
According to our talk with @ericvicenti about
renderScene
arguments