AHKNavigationController #5669
AHKNavigationController #5669
Conversation
Latest merge
Implemented this so that it re-enables the interactive pop gesture when the navigation bar is hidden or a custom back button is used.
|
By analyzing the blame information on this pull request, we identified @sahrens, @dougbankspersonal and @nicklockwood to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
I've manually patched this with RN 0.20. Works perfectly. Can we have this merged into the core? Thanks! |
|
Actually you have to add those files to the xcode project file. |
|
@insraq thanks for catching that! 👍 i just added it to the xcode project. hopefully this will get merged into the core. |
|
@yamill updated the pull request. |
|
@yamill updated the pull request. |
|
@yamill updated the pull request. |
|
This is a large PR and the NavigatorIOS is not maintained by Facebook so I don't think anyone has bandwidth to review this. Posted in this read-only group, feel free to follow along there: |
|
Actually I'll close this since the NavigatorIOS is not maintained. Feel free to copy the NavigatorIOS code into your project and modify it there, or fork it on your GitHub account. |
|
Thanks for understanding! |
This enables NavigatorIOS swipe-back when Navigation Bar is hidden.
Issue: #1341
See: https://github.com/fastred/AHKNavigationController for more detail