Add non-standardized timeout option to the fetch API #6504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @sahrens, @brentvatne and @whokilledtheelectricmonk to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
| jest.runAllTicks() | ||
| expect(XMLHttpRequest.mock.instances.length).toBe(1) | ||
| expect(XMLHttpRequest.mock.instances[0].timeout).toBe(42) | ||
| }) |
|
@lassebm updated the pull request. |
|
I may have glanced over the standard but it seems like |
|
I'm inclined to wait with this until fetch actually has it standardized (which also means the polyfill will be updated, see JakeChampion/fetch#175). In the meantime I think the workaround on that issue is sufficent. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to specify a timeout value other than the XMLHttpRequest default which is currently 0 (zero), i.e. no timeout.
The standardization work is tracked here: whatwg/fetch#20, whatwg/fetch#179.
Test: Unit test and manual verification in iOS project.