@facebook-github-bot feature is now a bit nicer to people #6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @bestander, @mkonicek and @janicduplessis to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
| @@ -36,5 +36,5 @@ comment Okay, reopening this issue. | |||
| reopen | |||
|
|
|||
| @facebook-github-bot feature | |||
| comment Hey {issue_author}! Thanks for opening the issue, however it looks like a feature request. As noted in the [Issue template](https://github.com/facebook/react-native/blob/master/ISSUE_TEMPLATE.md) we'd like to use the GitHub issues to track bugs only. Can you implement the feature as a standalone npm module? If not consider sending a pull request or a create an entry on [Product Pains](https://productpains.com/product/react-native). It has a voting system and if the feature gets upvoted enough it might get implemented. Will close this issue. | |||
| comment Hey {issue_author}! Thanks for opening the issue, however it looks like a feature request. As noted in the [Issue template](https://github.com/facebook/react-native/blob/master/ISSUE_TEMPLATE.md) we'd like to use the GitHub issues to track bugs only. Can you implement the feature as a standalone npm module? If not consider sending a pull request or a create an entry on [Product Pains](https://productpains.com/product/react-native). It has a voting system and if the feature gets upvoted enough it might get implemented. Closing this now due to the explanation above, thanks for understanding! | |||
There was a problem hiding this comment.
Closing this now due to the explanation above sounds wrong?
|
Looks good, thanks! Don't know how to add linebreaks actually.
Yeah, maybe just:
|
|
@bestander updated the pull request. |
|
@facebook-github-bot shipit |
|
let me know if there is anything to improve |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:mkonicek how can I add a line break to that? Closes facebook#6742 Differential Revision: D3120662 fb-gh-sync-id: 292ff3ae35c7ba4f583d3d3d4d5993812823e112 fbshipit-source-id: 292ff3ae35c7ba4f583d3d3d4d5993812823e112
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mkonicek how can I add a line break to that?