[NavigationExperimental] fixes a bug where NavigationPropTypes.SceneRenderer was a plain object #7518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @hedgerwang and @ericvicenti to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
This was referenced May 11, 2016
joenoon
force-pushed
the
jn-SceneRendererProps
branch
from
f012de1 to
92b557b
Compare
|
@joenoon updated the pull request. |
joenoon
force-pushed
the
jn-SceneRendererProps
branch
from
92b557b to
431b9a5
Compare
|
@joenoon updated the pull request. |
joenoon
force-pushed
the
jn-SceneRendererProps
branch
from
f92c782 to
93f4499
Compare
|
@joenoon updated the pull request. |
|
What is the preferred way to handle keeping the PR current with master? So far, I've been periodically rebasing against master and force pushing my branch. |
joenoon
force-pushed
the
jn-SceneRendererProps
branch
from
93f4499 to
83b03f3
Compare
|
@joenoon updated the pull request. |
joenoon
changed the title
used as both a shape and plain object. this splits them out so both parts can be used as needed. NavigationPropTypes.SceneRenderer is a PropTypes shape NavigationPropTypes.SceneRendererProps is the plain object that makes up the shape.
joenoon
force-pushed
the
jn-SceneRendererProps
branch
from
83b03f3 to
127479d
Compare
|
@joenoon updated the pull request. |
|
@ericvicenti just checking to see if this will make 0.26? (which I believe happens today?) It seems sort of important to get in. I just rebased it again, hoping that helps. |
|
@bestander @mkonicek what's the status here? |
|
@facebook-github-bot shipit |
|
Sorry about the delay on this one! |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
poppybank
pushed a commit
to poppybank/react-native
that referenced
this pull request
May 19, 2016
Summary: ... used as both a shape and plain object. this splits them out so both parts can be used as needed. NavigationPropTypes.SceneRenderer is a PropTypes shape NavigationPropTypes.SceneRendererProps is the plain object that makes up the shape. Closes facebook#7518 Differential Revision: D3317322 Pulled By: ericvicenti fbshipit-source-id: e8a31e05130e6647b63f68dbef31bc874550948c
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary: ... used as both a shape and plain object. this splits them out so both parts can be used as needed. NavigationPropTypes.SceneRenderer is a PropTypes shape NavigationPropTypes.SceneRendererProps is the plain object that makes up the shape. Closes facebook#7518 Differential Revision: D3317322 Pulled By: ericvicenti fbshipit-source-id: e8a31e05130e6647b63f68dbef31bc874550948c
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: ... used as both a shape and plain object. this splits them out so both parts can be used as needed. NavigationPropTypes.SceneRenderer is a PropTypes shape NavigationPropTypes.SceneRendererProps is the plain object that makes up the shape. Closes facebook#7518 Differential Revision: D3317322 Pulled By: ericvicenti fbshipit-source-id: e8a31e05130e6647b63f68dbef31bc874550948c
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: ... used as both a shape and plain object. this splits them out so both parts can be used as needed. NavigationPropTypes.SceneRenderer is a PropTypes shape NavigationPropTypes.SceneRendererProps is the plain object that makes up the shape. Closes facebook#7518 Differential Revision: D3317322 Pulled By: ericvicenti fbshipit-source-id: e8a31e05130e6647b63f68dbef31bc874550948c
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... used as both a shape and plain object.
this splits them out so both parts can be used as needed.
NavigationPropTypes.SceneRenderer is a PropTypes shape
NavigationPropTypes.SceneRendererProps is the plain object that makes up the shape.