Correctly reference cwd instead of __dirname #7671
Conversation
|
By analyzing the blame information on this pull request, we identified @janicduplessis and @martinbigio to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
What path will this display before and after your change? |
|
For 99% (or higher) of all uses, it will be exactly the same value as the previous value since I'm currently playing with a setup which allows passing the rn-cli.config.js file location to the bundler. As a result, |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
CLA Signed
|
Ok, I had a look at the code and it makes sense to show cwd in the error message since that is the directory we are searching in. Thanks for the fix! @facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Summary: This is for issue facebook#7670. I consider this a typo, but maybe you don't. In order to see the problem, you need to have the packager search for the configuration in a place that doesn't have one and the default configuration can't be provided. It's likely that no one is doing this and also why this probably wasn't seen. Closes facebook#7671 Differential Revision: D3350412 fbshipit-source-id: 5f9b520f7d5cbc749e2b898e7bbf2cd84d81ace0
Summary: This is for issue facebook#7670. I consider this a typo, but maybe you don't. In order to see the problem, you need to have the packager search for the configuration in a place that doesn't have one and the default configuration can't be provided. It's likely that no one is doing this and also why this probably wasn't seen. Closes facebook#7671 Differential Revision: D3350412 fbshipit-source-id: 5f9b520f7d5cbc749e2b898e7bbf2cd84d81ace0
Summary: This is for issue #7670. I consider this a typo, but maybe you don't. In order to see the problem, you need to have the packager search for the configuration in a place that doesn't have one and the default configuration can't be provided. It's likely that no one is doing this and also why this probably wasn't seen. Closes facebook/react-native#7671 Differential Revision: D3350412 fbshipit-source-id: 5f9b520f7d5cbc749e2b898e7bbf2cd84d81ace0
This is for issue #7670. I consider this a typo, but maybe you don't.
In order to see the problem, you need to have the packager search for the configuration in a place that doesn't have one and the default configuration can't be provided. It's likely that no one is doing this and also why this probably wasn't seen.