Fix issue where it breaks when projectRoots is directly passed from command line #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| options.projectRoots.push(path.resolve(root)); | ||
| }); | ||
| } | ||
| if('string' === typeof options.root) { |
There was a problem hiding this comment.
nit: can you add a space after the if
|
happy to pull this, just one nit |
…ommand line. - ./packager.sh --projectRoots ./ will break because project roots will become a string and breaks stuff
arasmussen
force-pushed
the
master
branch
5 times, most recently
from
9b61be2 to
41453a5
Compare
|
The source has become unknown repository when this went public, and my private clone wasn't available. Closing it now. Will rebase master and send another. |
|
I might have pulled this, but haven't really closed the issue. |
harrykiselev
pushed a commit
to harrykiselev/react-native
that referenced
this pull request
Aug 5, 2015
Update link in README
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
…okGH-85-Warnings-as-errors adding warning as error flag to circleCI
react-one
pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that using projectRoots and root as command line arguments breaks stuff.
./packager.sh --projectRoots ./will break because projectRoots will become a string.--rootis simple and--projectRootsis too big.This is just a minor fix and I would consider it to be better approach.