Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add closeOnScroll to SwipeableListView #8657

Closed
wants to merge 1 commit into from
Closed

add closeOnScroll to SwipeableListView #8657

wants to merge 1 commit into from

Conversation

chirag04
Copy link
Contributor

@chirag04 chirag04 commented Jul 8, 2016

motivation
This adds a convenience prop closeOnScroll that auto closes any open row when listview is scrolled. This is avery common behavior on listviews with swipeables.

test
set closeOnScroll=true on SwipeableListView and verified that it closes any open rows.

cc @fred2028 @satya164

@chirag04
Copy link
Contributor Author

chirag04 commented Jul 8, 2016 •
edited
Loading

maybe rename the prop to closeRowOnScroll or closeOpenRowOnScroll? I took inspiration from https://github.com/jemise111/react-native-swipe-list-view

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @fred2028 and @sscaff1 to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 8, 2016
@ghost
Copy link

ghost commented Aug 7, 2016

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @fred2028 as a potential reviewer. Could you take a look please or cc someone with more context?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 7, 2016
@chirag04 chirag04 closed this Sep 22, 2016
@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 22, 2016
@chirag04
Copy link
Contributor Author

Landed on master today.

@satya164 satya164 deleted the chirag04-patch-3 branch October 9, 2016 18:08
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag04 @facebook-github-bot