[Packager] Windows support for Packager - Blacklist changes #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
| // Don't forget to everything listed here to `testConfig.json` | ||
| // modulePathIgnorePatterns. | ||
| var sharedBlacklist = [ | ||
| __dirname, | ||
| 'website', | ||
| '/.git', // added because nodeWatcher does not ignore hidden files |
There was a problem hiding this comment.
recently fixed this error in sane -- the file watcher.
There was a problem hiding this comment.
Great, also noticed you fixed the NodeWatcher creation to pass an object with glob as a field, which seem to fix an issue where the glob pattern was being ignored.
|
This looks good. Will pull shortly |
|
@amasad - did this ever get pulled? |
brentvatne
changed the title
|
Looks like it wasn't :/ I'll pull it |
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary: Another Pull Request implementing the changes in issue #468 - Enabled Packager to run on Windows This change relates to the blacklist fixes. It includes the path conversion for blacklist and changes to the default watched directory. It has no impact on Mac OSX. Closes facebook/react-native#893 Github Author: Joe Wood <joewood> Test Plan: Imported from GitHub, without a `Test Plan:` line.
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
Clarifying a sentence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another Pull Request implementing the changes in issue #468 - Enabled Packager to run on Windows
This change relates to the blacklist fixes. It includes the path conversion for blacklist and changes to the default watched directory. It has no impact on Mac OSX.